Better app version number handling. #67

ArthurKValladares · 2022-02-17T23:24:07Z

No description provided.

src/util/mod.rs

src/apple/target.rs

src/apple/cli.rs

src/apple/config/mod.rs

src/util/mod.rs

src/apple/target.rs

src/util/mod.rs

src/apple/config/mod.rs

src/apple/target.rs

src/apple/mod.rs

src/apple/version_number.rs

src/apple/cli.rs

src/apple/version_number.rs

src/apple/cli.rs

francesca64

Great work!

ArthurKValladares and others added 18 commits October 21, 2021 13:29

Add back missing closing delimiter to app_dependencies_platform

9f8984f

Merge branch 'master' of https://github.com/BrainiumLLC/cargo-mobile

0c1e7b0

Merge branch 'master' of https://github.com/BrainiumLLC/cargo-mobile

3e500f2

Merge branch 'master' of https://github.com/BrainiumLLC/cargo-mobile

d1e330b

Merge branch 'master' of https://github.com/BrainiumLLC/cargo-mobile

f7d8656

Merge branch 'master' of https://github.com/BrainiumLLC/cargo-mobile

678df1e

Merge branch 'master' of https://github.com/BrainiumLLC/cargo-mobile

31f0915

Merge branch 'master' of https://github.com/BrainiumLLC/cargo-mobile

19f31cd

Merge branch 'master' of https://github.com/BrainiumLLC/cargo-mobile

70de330

Start working on supporting version numbers with N numbers

e00d2c0

Mode progress on Version Struct that supports N versions

7205dac

Let user specify a longer VersionNumber

bbe878e

Progress on setting build version

7bbc6b8

Remove Build number from Raw/Config

aea9938

Slight cleanup to getting app version in Archive

ac99bd3

Progress on setting app version for xcodebuild

0399763

fix agvtool command

f98e903

Add more error logging for ios bundle versions

c48b993

ArthurKValladares requested a review from francesca64 February 17, 2022 23:24

francesca64 suggested changes Feb 22, 2022

View reviewed changes

ArthurKValladares added 10 commits February 22, 2022 13:45

Rename ret to result

554bdae

Rename WithCurrentDirError to WithWorkingDirError

c1a47d2

remove std::path::* specifier

56a551f

Fix Typo

f2e5c6c

Fix typo

b870a98

Rename IosVersionNumberError

2d2f1b1

Use impure command for xcrun

68f40fe

cleanup

b16da10

make InvalidVersionConfiguration error message more clear

6d5e896

a bit more cleanup

b7cadc5

ArthurKValladares added 6 commits February 22, 2022 15:41

add from_other_and_number to VersionNumber

3cd8eac

simplify xcrun command

66d6181

Merge branch 'master' of https://github.com/BrainiumLLC/cargo-mobile

98931ed

Merge branch 'master' into version-number

29289de

Add back Pod use

46233cc

fix xcrun command

0a4c0fc

ArthurKValladares requested a review from francesca64 February 23, 2022 00:17

ArthurKValladares added 2 commits February 23, 2022 12:23

roll back to pure parse for xcrun

b092985

better with_working_dir

be02f34

francesca64 suggested changes Feb 24, 2022

View reviewed changes

ArthurKValladares added 6 commits February 24, 2022 15:02

Make VersionNumber iOS only

2256b1a

point-free

9439527

Remove trivial from_version_number function

142f6ca

some more point-frees

1943463

err instead of cause

53f5f89

map free once again

40d3249

francesca64 suggested changes Feb 26, 2022

View reviewed changes

ArthurKValladares added 3 commits February 25, 2022 16:27

small cleanup

9f20a02

cleanup a bit more

cd2662c

Use push_extra instead of from_other_and_number

5000670

ArthurKValladares requested a review from francesca64 March 2, 2022 19:36

francesca64 suggested changes Mar 3, 2022

View reviewed changes

src/apple/cli.rs Outdated Show resolved Hide resolved

src/apple/version_number.rs Show resolved Hide resolved

src/apple/version_number.rs Outdated Show resolved Hide resolved

src/apple/version_number.rs Outdated Show resolved Hide resolved

src/apple/cli.rs Outdated Show resolved Hide resolved

cleanup

ccc8f8a

ArthurKValladares requested a review from francesca64 March 3, 2022 20:53

francesca64 approved these changes Mar 3, 2022

View reviewed changes

Merge branch 'master' into version-number

d6959a7

francesca64 merged commit cc755c4 into master Mar 3, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Better app version number handling. #67

Better app version number handling. #67

ArthurKValladares commented Feb 17, 2022

francesca64 left a comment

Better app version number handling. #67

Better app version number handling. #67

Conversation

ArthurKValladares commented Feb 17, 2022

francesca64 left a comment

Choose a reason for hiding this comment