Specify library path env var. #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
francesca64
suggested changes
Dec 7, 2021
src/apple/cli.rs
Outdated
| @@ -399,6 +399,7 @@ impl Exec for Input { | |||
| let macos_target = Target::macos(); | |||
|
|
|||
| let isysroot = format!("-isysroot {}", sdk_root.display()); | |||
| let library_path = format!("{}/usr/lib", macos_sdk_root.display()); | |||
There was a problem hiding this comment.
Having this be part of the macos_isysroot expression (binding (macos_isysroot, library_path)) would prevent needing to expose macos_sdk_root; the (pre-existing) large number of bindings derived from each other can make this function difficult to reason about, so being aggressive about constraining that flow is warranted.
francesca64
suggested changes
Dec 7, 2021
src/apple/cli.rs
Outdated
| format!("-isysroot {}", macos_sdk_root.display()) | ||
| ( | ||
| format!("-isysroot {}", macos_sdk_root.display()), | ||
| // We need to manually specify a search path to link against the host's libraries for MacOs Big Sur |
There was a problem hiding this comment.
More direct description of why we have this:
Suggested change
| // We need to manually specify a search path to link against the host's libraries for MacOs Big Sur | |
| // Prevents linker errors in build scripts and proc macros: |
Also, this should be on the LIBRARY_PATH insert instead of here.
francesca64
approved these changes
Dec 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
linking with ccerror where cc can't find os libs.