Allow user to specify legacy or new build system. #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
francesca64
suggested changes
Nov 10, 2021
src/apple/config/raw.rs
Outdated
| @@ -51,6 +51,7 @@ pub struct Raw { | |||
| pub ios_features: Option<Vec<String>>, | |||
| pub macos_no_default_features: Option<bool>, | |||
| pub macos_features: Option<Vec<String>>, | |||
| pub use_legacy_build_system: bool, | |||
There was a problem hiding this comment.
I'm pretty sure that this not being wrapped in an Option will result in it unconditionally being written to mobile.toml, when ideally we want it to be unspecified by default (defaulting to true when upgrading to non-raw Config)
francesca64
reviewed
Nov 15, 2021
src/apple/config/mod.rs
Outdated
| @@ -193,11 +194,12 @@ impl Config { | |||
| ); | |||
| Ok(DEFAULT_PROJECT_DIR.to_owned()) | |||
| })?; | |||
|
|
|||
| let use_legacy_build_system = raw.use_legacy_build_system.unwrap_or(true); | |||
There was a problem hiding this comment.
Keeping this inline is fine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.