Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Ping Monitor improvements #2573

Merged
merged 11 commits into from
Dec 9, 2023
Merged

Feature: Ping Monitor improvements #2573

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
4c5c470
Feature: Ping Monitor improvements
BornToBeRoot Dec 3, 2023
a60869c
Feature: DNS Lookup / Port Scanner improve group string
BornToBeRoot Dec 3, 2023
cf7ccf7
Feature: Host range aded to Ping Monitor & new design
BornToBeRoot Dec 4, 2023
f949ecf
Feature: Allow range in profile
BornToBeRoot Dec 4, 2023
0f5a3b3
Feature: Ping Monitor
BornToBeRoot Dec 5, 2023
a0eabbc
Feature: Setting to expand host view
BornToBeRoot Dec 8, 2023
6d50b5d
Feature: Expand ping monitor host
BornToBeRoot Dec 8, 2023
c5c5994
Docs: Ping Monitor
BornToBeRoot Dec 8, 2023
fa0df91
Chore: Refactoring
BornToBeRoot Dec 9, 2023
c3d8c47
Feature: Ping Monitor
BornToBeRoot Dec 9, 2023
f71165b
Docs: Update img
BornToBeRoot Dec 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Feature: Ping Monitor
  • Loading branch information
@BornToBeRoot
BornToBeRoot committed Dec 9, 2023
commit c3d8c47773104a75d702ccfcdf6ba9c5c81a8238
21 changes: 0 additions & 21 deletions Source/NETworkManager.Models/Network/HostNotFoundException.cs
View file
Open in desktop

This file was deleted.

5 changes: 0 additions & 5 deletions Source/NETworkManager.Models/Network/HostRangeHelper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,6 @@ private static (List<(IPAddress ipAddress, string hostname)> hosts, List<string>
var hostsBag = new ConcurrentBag<(IPAddress ipAddress, string hostname)>();
var hostnamesNotResovledBag = new ConcurrentBag<string>();

var exceptions = new ConcurrentQueue<HostNotFoundException>();

Parallel.ForEach(hosts, new ParallelOptions { CancellationToken = cancellationToken }, host =>
{
switch (host)
Expand Down Expand Up @@ -202,9 +200,6 @@ private static (List<(IPAddress ipAddress, string hostname)> hosts, List<string>
}
});

if (!exceptions.IsEmpty)
throw new AggregateException(exceptions);

// Sort list and return
IPAddressComparer comparer = new();

Expand Down
9 changes: 7 additions & 2 deletions docs/Changelog/next-release.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,10 +32,15 @@ Experimental features can be enabled in the settings under [`Settings > Update`]

## Improvements

- IP Scanner
- Scan is no longer aborted if the IP of a single host in a series of hosts cannot be resolved (the host is skipped and an error is displayed) [#2573](https://github.com/BornToBeRoot/NETworkManager/pull/2573){:target="\_blank"}
- Port Scanner
- Hostname added to group
- Scan is no longer aborted if the IP of a single host in a series of hosts cannot be resolved (the host is skipped and an error is displayed) [#2573](https://github.com/BornToBeRoot/NETworkManager/pull/2573){:target="\_blank"}
- Hostname added to group [#2573](https://github.com/BornToBeRoot/NETworkManager/pull/2573){:target="\_blank"}
- Ping Monitor
- Scan is no longer aborted if the IP of a single host in a series of hosts cannot be resolved (the host is skipped and an error is displayed) [#2573](https://github.com/BornToBeRoot/NETworkManager/pull/2573){:target="\_blank"}
- DNS Lookup
- Hostname of the nameserver added to group
- Hostname of the nameserver added to group [#2573](https://github.com/BornToBeRoot/NETworkManager/pull/2573){:target="\_blank"}

## Bugfixes

Expand Down