Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update language stats in GUI #396

Closed
bovirus opened this issue Dec 14, 2020 · 10 comments
Closed

Update language stats in GUI #396

bovirus opened this issue Dec 14, 2020 · 10 comments
Labels

Comments

@bovirus
Copy link
Contributor

bovirus commented Dec 14, 2020

@BornToBeRoot

Describe your issue:

Language status inside program seems not update (compared with Transiflex). Example

Here there are some big differences

Italian - 75.8% (Transiflex) - 30.49% (GUI) - More than 50% in GUI!
Russian - 70.3% (Transiflex) - 70.88% (GUI) - Small differences (0.5%)
Polish (Poland) - 30.5% (Transiflex) - 76.44% (GUI) - Big differences (strange: GUI is more updated than Transiklex).

Steps to reproduce the issue:

NETworkManager version:

Windows version:

.NET-Framework version:

Screenshots

Eventlog (if application crashes)
@BornToBeRoot
Copy link
Owner

Looks like i switched Italian and Polish.

I will update it in the next release.

There might be a difference since I updated the language resources with version 2020.12.0.

Can you send me a PR for the inno setup file?

@BornToBeRoot BornToBeRoot changed the title NteworkManger 2020.12.1 Update language stats in GUI Dec 14, 2020
@bovirus
Copy link
Contributor Author

bovirus commented Dec 14, 2020

Hello.

I had already made a PR for the Inno Setup but it seems disapearred.

I finalized the Italian translation.
Now is translated at 100% (on Transiflex).

@bovirus
Copy link
Contributor Author

bovirus commented Dec 14, 2020

@BornToBeRoot

Update Inno Setup script

#397

[Languages]
Name: "brasilian"; MessagesFile: "compiler:Languages\BrazilianPortuguese.isl"
Name: "czech"; MessagesFile: "compiler:Languages\Czech.isl"
Name: "dutch"; MessagesFile: "compiler:Languages\Dutch.isl"
Name: "french"; MessagesFile: "compiler:Languages\French.isl"
Name: "italian"; MessagesFile: "compiler:Languages\Italian.isl"
Name: "japanese"; MessagesFile: "compiler:Languages\Japanese.isl"
Name: "polish"; MessagesFile: "compiler:Languages\Polish.isl"
Name: "spanish"; MessagesFile: "compiler:Languages\Spanish.isl"
Name: "turkish"; MessagesFile: "compiler:Languages\Turkish.isl"

@BornToBeRoot
Copy link
Owner

@bovirus great. I will update the language files with the next release and add your username to the translators list.

@bovirus
Copy link
Contributor Author

bovirus commented Dec 14, 2020

@BornToBeRoot

Thanks.
I hope to see an important improvemnts like program vesion in main window.
Example in top left of main windowss.

NETworkManager 2020.12.1

@BornToBeRoot
Copy link
Owner

I had the version in previous versions in the status bar. But does it really make sense? If an update is available it is disaplayed in the title bar:

image

BornToBeRoot added a commit that referenced this issue Dec 14, 2020
@BornToBeRoot
Copy link
Owner

@bovirus Can i close the issue?

Update for the stats: #396

PR #397 is merged.

@bovirus
Copy link
Contributor Author

bovirus commented Dec 15, 2020

@BornToBeRoot

Yes sure.
Please if you can make a new build with new language (Italian) to test the new installer/language.

@bovirus
Copy link
Contributor Author

bovirus commented Dec 15, 2020

@BornToBeRoot

New build of installer but seems that there are some issues

#401

@BornToBeRoot
Copy link
Owner

I will update the language files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants