Singleton types for factors and cyclic groups #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces singleton types for factors and cyclic groups, which maintain a link between a type-level modulo and a term-level value (factorisation or structure of respective cyclic group). It closes #154 and is a major redesign of cyclic groups and primitive roots API.
It also affects modular square roots and modular equations, providing an ergonomical way to have a type-level proof that all computations are for the same modulo, without compromising performance by repetitive factorisation of modulo.
@b-mehta could you please review this in your spare time?