Skip to content

Commit

Permalink
Fix tox extras and linting
Browse files Browse the repository at this point in the history
  • Loading branch information
eleftherioszisis committed Jan 19, 2022
1 parent 4134791 commit a87bcf4
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 5 deletions.
5 changes: 2 additions & 3 deletions tox.ini
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,6 @@ name = vascpy
testdeps =
mock
pytest
vtk
extras = all

[tox]
minversion = 3.1.0
Expand All @@ -15,6 +13,7 @@ envlist =
ignore_basepython_conflict = true

[testenv]
extras = all
deps = {[base]testdeps}
commands = py.test {posargs} tests

Expand All @@ -39,7 +38,7 @@ commands =
black -l 100 --check {[base]name} tests setup.py
mypy --ignore-missing-imports {[base]name}
pycodestyle {[base]name}
pylint -j2 {[base]name}
pylint -j2 --ignored-modules=vtk {[base]name}

[testenv:py39-coverage]
deps =
Expand Down
5 changes: 4 additions & 1 deletion vascpy/conversion.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@
import logging
import tempfile
from collections import deque
from dataclasses import dataclass

import h5py
import numpy as np
Expand All @@ -36,6 +35,8 @@
class ColsPoints:
"""Enumeration for point array columns"""

# pylint: disable=too-few-public-methods

X = 0
Y = 1
Z = 2
Expand All @@ -44,6 +45,8 @@ class ColsPoints:
class ColsEdges:
"""Enumeration for edge property columns"""

# pylint: disable=too-few-public-methods

BEG_NODE = 0
END_NODE = 1
EDGE_TYPE = 2
Expand Down
3 changes: 2 additions & 1 deletion vascpy/specs.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
See the License for the specific language governing permissions and
limitations under the License.
"""
# pylint: disable=too-few-public-methods
import typing

import numpy as np
Expand All @@ -28,7 +29,7 @@ class _SpecType(typing.NamedTuple):
class SpecPointVasculature:
"""PointVasculature specification"""

# pylint: disable=invalid-name, bad-option-value, too-many-instance-attributes
# pylint: disable=invalid-name, too-many-instance-attributes

X: _SpecType = _SpecType("x", np.float32)
Y: _SpecType = _SpecType("y", np.float32)
Expand Down

0 comments on commit a87bcf4

Please sign in to comment.