Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploying new neurodamus 3 series #933

Merged
merged 1 commit into from
Oct 12, 2020
Merged

Deploying new neurodamus 3 series #933

merged 1 commit into from
Oct 12, 2020

Conversation

ferdonline
Copy link

No description provided.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these ever deployed without +coreneuron? May be worth changing the default in the future (does not have to be this PR)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think deployed not... but when building locally, personally I find that the default ~Coreneuron makes more sense

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough! The new deployment will use environments (when I finally pull the trigger, waiting for some upstream goodies), and we should be able to fix it there.

Within environments, we can actually override parts of packages.yaml and pin +coreneuron there — that will not affect users, and make these specs easier to read :)

@ferdonline ferdonline merged commit 8423839 into develop Oct 12, 2020
@ferdonline ferdonline deleted the deploy/neurodamus3 branch October 12, 2020 18:27
@pramodk
Copy link

pramodk commented Oct 12, 2020

we do want to get newer neuron and coreneuron deployed. Is that included now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants