Adding Neurodamus new series (3.0) #932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Neurodamus-Core, -py and all models were bumped to latest version a major one due to different behavior (eg RNG...) and incompat with old models (Delayed connections)
* switched on submodules for version 0.21a * added explicit dependency on python * modified cmake arguments to pick up correct python version Co-authored-by: Pramod Kumbhar <[email protected]>
matz-e
approved these changes
Oct 12, 2020
| @@ -19,7 +19,8 @@ class Coreneuron(CMakePackage): | |||
| git = "https://github.com/BlueBrain/CoreNeuron" | |||
|
|
|||
| version('develop', branch='master', submodules=True) | |||
| version('0.21a', commit="bf3c823", preferred=True) | |||
| version('0.22', tag='0.22', submodules=True, preferred=True) | |||
There was a problem hiding this comment.
BTW, if these are ordered, the preferred can be dropped for the latest version. Spack by default will prefer the largest "numerical" version.
There was a problem hiding this comment.
yes, some recipes have it, not sure why, and in this case came from the coreneuron merge
@ALL let's keep this in mind for next changes
There was a problem hiding this comment.
Just wanted to point that out for reference :)
It's a somewhat historic artefact…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Neurodamus-Core, -py and all models were bumped to latest version, a major one due to different behavior (eg RNG...) and incompat with old models (Delayed connections)
Brings: