Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update py-neurodamus to v1.3.2 #925

Merged
merged 1 commit into from
Sep 30, 2020
Merged

update py-neurodamus to v1.3.2 #925

merged 1 commit into from
Sep 30, 2020

Conversation

WeinaJi
Copy link

@WeinaJi WeinaJi commented Sep 30, 2020

No description provided.

@pramodk
Copy link

pramodk commented Sep 30, 2020

@WeinaJi @ferdonline : does this include change of random123 change? also, what about hoc version? anything needs to be related there?

@WeinaJi
Copy link
Author

WeinaJi commented Sep 30, 2020

Hi @pramodk
The random123 change is included in this release.
With the latest change in the release, py-neurodamus doesn't depend on the hoc update for delay connections, i.e. it can run without the hoc update for simulations which don't have delay connections. As for hoc version, Omar is debugging an issue of delay connections for coreneuron (CNEUR-360), so I guess it won't be deployed today.

ferdonline
ferdonline previously approved these changes Sep 30, 2020
View reviewed changes
@WeinaJi
Copy link
Author

WeinaJi commented Sep 30, 2020

please retest

@WeinaJi
update py-neurodamus to v1.3.2 including changes:
bfc5f58 
    Numpy output minimum 1-d array in case of single spike in SynapseReplay (BBPBGLIB-661)
    Fixes for spike with negative time (BBPBGLIB-367)
    Assign fake gids to ARTIFICIAL_CELLs in CORENEURON empty threads
@WeinaJi WeinaJi merged commit cb194c1 into develop Sep 30, 2020
@WeinaJi WeinaJi deleted the bump_pyneurodamus branch September 30, 2020 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pramodk pramodk pramodk approved these changes

@ferdonline ferdonline ferdonline left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@WeinaJi @pramodk @ferdonline