-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes for Neurodamus and Mac instructions #841
Conversation
Neurodamus, when building in mac suffered from two issues: - always assume a brew Python - link to neurodamus-core with "run" dependency, which made it load modules and have variables overwritten. See #757 (comment) To fix these issues, the dependency was changed to "link", the hardcoded Python version was removed and instructions how to use BlueBrain spack with Mac were added.
README.md
Outdated
## Building software in MAC | ||
|
||
<details> | ||
<summary> | ||
Install software in MAC. Use BREW as a source of binary packages | ||
</summary> | ||
|
||
In MAC the build process is very similar to Ubuntu. To avoid building | ||
the whole stack from source we can likewise use a package manager. | ||
For that end we have successfully used Brew. We also provide a skeleton | ||
packages.yaml that you should review and adapt to your needs. | ||
|
||
Before starting, please install brew and the required packages. | ||
If you require Python please install a version dowloaded from | ||
Python.org, as several issues have been found with "brewed" Python |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for getting this started! I'm thinking we could probably move this section up underneath the Ubuntu ones?
## Building software in MAC | |
<details> | |
<summary> | |
Install software in MAC. Use BREW as a source of binary packages | |
</summary> | |
In MAC the build process is very similar to Ubuntu. To avoid building | |
the whole stack from source we can likewise use a package manager. | |
For that end we have successfully used Brew. We also provide a skeleton | |
packages.yaml that you should review and adapt to your needs. | |
Before starting, please install brew and the required packages. | |
If you require Python please install a version dowloaded from | |
Python.org, as several issues have been found with "brewed" Python | |
## Building software on OS X | |
<details> | |
<summary> | |
Install software on OS X, using Homebrew for binary packages | |
</summary> | |
On OS X the build process is very similar to Ubuntu. To avoid building | |
the whole stack from source we can likewise use another package manager to provide precompiled binaries. | |
To that end we have successfully used Homebrew. We also provide a skeleton | |
`packages.yaml` that you should review and adapt to your needs. | |
Before starting, please install brew and the required packages. | |
If you require Python please install a version dowloaded from | |
Python.org, as several issues have been found with Homebrew's Python |
Which packages are required? Also, rather than downloading an external Python, Spack could just build it…
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which packages are required? Also, rather than downloading an external Python, Spack could just build it…
Not a bad idea, if we nail all its dependencies beforehand, takes ~6 mins to build. @ferdonline what do you say about adopting this strategy? Brew's Python is also causing issues with wheels as far as you were pointing out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The issue is not the build time, even though is not negligible. The issue is that it will probably end up with the same issues as brew Python... Python from Python.org are the standard ones, build with well tested settings and env vars for retro versions compatibility. I think it should be the default. Mac users only have to download and install, not like the linux world.
@@ -0,0 +1,111 @@ | |||
packages: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can come in handy in a future update of our spack :
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not in our tree yet :(
Co-authored-by: Matthias Wolf <[email protected]>
Spack will also autoload link dependencies
Neurodamus link dependency and Mac instructions Neurodamus, when building in mac suffered always assumed a brew Python Updated README.md for Mac usage Co-authored-by: Matthias Wolf <[email protected]>
Neurodamus, when building in mac suffered from two issues:
it load modules and have variables overwritten. See
[BSD-118][macOS][python][dyld] spack install fails because of static linking #757 (comment)
This PR
the dependency was changed to "link",(doesn't help) - in the future we should remove the dependency altogether and use submodule