Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

py-bbp-workflow-cli: bump #1849

Merged
merged 1 commit into from
Mar 1, 2023
Merged

py-bbp-workflow-cli: bump #1849

merged 1 commit into from
Mar 1, 2023

Conversation

genric
Copy link

@genric genric commented Feb 27, 2023

No description provided.

@bbpbuildbot
Copy link
Collaborator

Thank you for your pull request!

Should you want to clear the PR build directory after failures, please use this pipeline. Before running the cleanup pipeline, please ensure that any PR building pipelines have been cancelled or finished running.

matz-e
matz-e previously approved these changes Feb 27, 2023
Copy link
Member

@matz-e matz-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a word of caution: I think that Spack removes all non-numeric components, and 3.1.1 may be considered less than the .dev0 version. If such conflicts arise, or as a general good practice, in the future we can deprecate the .dev0 version with the option deprecated=True to the version directive.

@bbpbuildbot
Copy link
Collaborator

To test your PR, use the following on BlueBrain5:

unset MODULEPATH
. /gpfs/bbp.cscs.ch/ssd/apps/bsd/pulls/1849/config/modules.sh
module load unstable

Please test the following updated modules:

  • psp-validation/0.5.0
  • py-bbp-workflow-cli/3.1.1.dev0

@genric
Copy link
Author

genric commented Feb 27, 2023

@matz-e thanks for the info! After we'll run some tests I'm hoping to make a proper version release from this draft...

@bbpbuildbot
Copy link
Collaborator

To test your PR, use the following on BlueBrain5:

unset MODULEPATH
. /gpfs/bbp.cscs.ch/ssd/apps/bsd/pulls/1849/config/modules.sh
module load unstable

Please test the following updated modules:

  • psp-validation/0.5.0
  • py-bbp-workflow-cli/3.1.1.dev1

@genric genric marked this pull request as ready for review March 1, 2023 08:50
@genric genric enabled auto-merge (squash) March 1, 2023 08:50
@genric genric requested a review from matz-e March 1, 2023 08:50
@bbpbuildbot
Copy link
Collaborator

To test your PR, use the following on BlueBrain5:

unset MODULEPATH
. /gpfs/bbp.cscs.ch/ssd/apps/bsd/pulls/1849/config/modules.sh
module load unstable

Please test the following updated modules:

  • psp-validation/0.5.0
  • py-bbp-workflow-cli/3.1.1

@genric
Copy link
Author

genric commented Mar 1, 2023

@matz-e, can we merge this? or we need to wait for mega merge?

Copy link
Member

@matz-e matz-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get this in, then I'll redeploy the new Spack after unstable has been updated.

@genric genric merged commit c5e5d8f into develop Mar 1, 2023
@genric genric deleted the bbp-workflow-cli branch March 1, 2023 11:16
@genric
Copy link
Author

genric commented Mar 1, 2023

Great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants