Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds missing module to viz environment #1769

Merged
merged 5 commits into from
Nov 17, 2022

Conversation

NadirRoGue
Copy link

No description provided.

@bbpbuildbot
Copy link
Collaborator

Thank you for your pull request!

Should you want to clear the PR build directory after failures, please use this pipeline. Before running the cleanup pipeline, please ensure that any PR building pipelines have been cancelled or finished running.

@bbpbuildbot
Copy link
Collaborator

To test your PR, use the following on BlueBrain5:

unset MODULEPATH
. /gpfs/bbp.cscs.ch/ssd/apps/bsd/pulls/1769/config/modules.sh
module load unstable

Copy link
Member

@matz-e matz-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see the module in the list to test, don't you need to add it below to the specs: key, too?

@NadirRoGue
Copy link
Author

Actually, I added it on the specs: and forgot to add it on the modules: . Thanks for spotting it!

@bbpbuildbot
Copy link
Collaborator

The following build jobs of the deployment for this PR failed:

@bbpbuildbot
Copy link
Collaborator

The following build jobs of the deployment for this PR failed:

@NadirRoGue
Copy link
Author

@matz-e Where should I add py-websockets so that it can be used for py-brayns?

@@ -25,6 +25,7 @@ spack:
- py-scikit-learn
- py-scipy
- py-tensorflow
- py-websockets
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both these modifications should disappear again, no changes to libraries needed.

I overlooked it, but py-websockets needs to be a dependency with type=("build", "run"), as that should be always done for Python dependencies.

Copy link
Author

@NadirRoGue NadirRoGue Nov 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I applied these changes.

@bbpbuildbot
Copy link
Collaborator

The following build jobs of the deployment for this PR failed:

@bbpbuildbot
Copy link
Collaborator

The following build jobs of the deployment for this PR failed:

@bbpbuildbot
Copy link
Collaborator

To test your PR, use the following on BlueBrain5:

unset MODULEPATH
. /gpfs/bbp.cscs.ch/ssd/apps/bsd/pulls/1769/config/modules.sh
module load unstable

Please test the following updated modules:

  • py-brayns/3.0.0

@NadirRoGue NadirRoGue merged commit 2b58ac1 into develop Nov 17, 2022
@NadirRoGue NadirRoGue deleted the add_missing_py_brayns_to_environment branch November 17, 2022 12:07
matz-e pushed a commit that referenced this pull request Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants