-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds missing module to viz environment #1769
Conversation
Thank you for your pull request! Should you want to clear the PR build directory after failures, please use this pipeline. Before running the cleanup pipeline, please ensure that any PR building pipelines have been cancelled or finished running. |
To test your PR, use the following on BlueBrain5: unset MODULEPATH
. /gpfs/bbp.cscs.ch/ssd/apps/bsd/pulls/1769/config/modules.sh
module load unstable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see the module in the list to test, don't you need to add it below to the specs:
key, too?
Actually, I added it on the |
The following build jobs of the deployment for this PR failed: |
The following build jobs of the deployment for this PR failed: |
@matz-e Where should I add py-websockets so that it can be used for py-brayns? |
@@ -25,6 +25,7 @@ spack: | |||
- py-scikit-learn | |||
- py-scipy | |||
- py-tensorflow | |||
- py-websockets |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both these modifications should disappear again, no changes to libraries
needed.
I overlooked it, but py-websockets
needs to be a dependency with type=("build", "run")
, as that should be always done for Python dependencies.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I applied these changes.
The following build jobs of the deployment for this PR failed: |
The following build jobs of the deployment for this PR failed: |
To test your PR, use the following on BlueBrain5: unset MODULEPATH
. /gpfs/bbp.cscs.ch/ssd/apps/bsd/pulls/1769/config/modules.sh
module load unstable Please test the following updated modules:
|
No description provided.