Neurodamus-models to depend on neurodamus-py (bringing core) #1406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pramodk
reviewed
Dec 21, 2021
Keeping old function version_from_model_core_dep to enable building latest stable deployed version depending still on neurodamus-core. Changed recipes to call the function once per version for readability
matz-e
reviewed
Dec 22, 2021
matz-e
previously requested changes
Dec 29, 2021
14a22c2
to
544633f
Compare
1455264
to
d7c20e3
Compare
jorblancoa
reviewed
Jan 12, 2022
jorblancoa
reviewed
Jan 12, 2022
var/spack/repos/builtin/packages/neurodamus-neocortex/package.py
Outdated
Show resolved
Hide resolved
jorblancoa
reviewed
Jan 12, 2022
var/spack/repos/builtin/packages/neurodamus-hippocampus/package.py
Outdated
Show resolved
Hide resolved
jorblancoa
reviewed
Jan 12, 2022
Conflicts: bluebrain/repo-bluebrain/packages/neurodamus-hippocampus/package.py bluebrain/repo-bluebrain/packages/neurodamus-mousify/package.py bluebrain/repo-bluebrain/packages/neurodamus-neocortex/package.py bluebrain/repo-bluebrain/packages/neurodamus-thalamus/package.py deploy/environments/libraries.yaml var/spack/repos/builtin/packages/py-charm4py/package.py
70ac82c
to
015a737
Compare
|
To test your PR, use the following on BlueBrain5: unset MODULEPATH
. /gpfs/bbp.cscs.ch/ssd/apps/bsd/pulls/1406/config/modules.sh
module load unstablePlease test the following updated modules: |
fd65cc7
to
160c927
Compare
|
To test your PR, use the following on BlueBrain5: unset MODULEPATH
. /gpfs/bbp.cscs.ch/ssd/apps/bsd/pulls/1406/config/modules.sh
module load unstablePlease test the following updated modules: |
|
To test your PR, use the following on BlueBrain5: unset MODULEPATH
. /gpfs/bbp.cscs.ch/ssd/apps/bsd/pulls/1406/config/modules.sh
module load unstablePlease test the following updated modules: |
|
To test your PR, use the following on BlueBrain5: unset MODULEPATH
. /gpfs/bbp.cscs.ch/ssd/apps/bsd/pulls/1406/config/modules.sh
module load unstablePlease test the following updated modules: |
matz-e
reviewed
Jan 25, 2022
|
To test your PR, use the following on BlueBrain5: unset MODULEPATH
. /gpfs/bbp.cscs.ch/ssd/apps/bsd/pulls/1406/config/modules.sh
module load unstablePlease test the following updated modules: |
|
To test your PR, use the following on BlueBrain5: unset MODULEPATH
. /gpfs/bbp.cscs.ch/ssd/apps/bsd/pulls/1406/config/modules.sh
module load unstablePlease test the following updated modules: |
matz-e
approved these changes
Jan 26, 2022
|
To test your PR, use the following on BlueBrain5: unset MODULEPATH
. /gpfs/bbp.cscs.ch/ssd/apps/bsd/pulls/1406/config/modules.sh
module load unstablePlease test the following updated modules: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As part of the repo reorganization (2021), neurodamus-core becomes officially an addendum to neurodamus-py
This PR changes the way neurodamus is built, and ultimately loaded, by setting neurodamus-py as a direct dependency of the models.
Context
Neurodamus-core has became a submodule of neurodamus-py to support the long term goal of dropping it if favor of pure Python. Consequently it can/must no longer be considered a main package.
We therefore make neurodamus-models to depend directly on neurodamus-py, since it brings it all, which streamlines the process of building, deploying and even loading.
The end user will be able to simply load e.g.
neurodamus-neocortexand have a fully functional environment with guaranteed cross-compatibility of the neocortex model, core and (Edit: Soon) neurodamus-py.Edit: We disabled auto-loading neurodamus-py since it will bring the intel stack, which is not optimal because we may need to use other stacks (bglig-py...). These issues should be addresses in a dedicated ticket.
Extra
Bumped neurodamus-py to 2.10.0, bringing