Add tests for BEFORE/AFTER block

[alkino]

Should fix #946

[ohm314]

@alkino did you see the spack failure on the bbpgitlab CI? Maybe it has something to do with the updated neuron@develop that was mentioned today? I think once this hickup is fixed and maybe the tests are just a little bit expanded we can merge this.

[bbpbuildbot]

Logfiles from GitLab pipeline #93370 (:white_check_mark:) have been uploaded here!

Status and direct links:

• ✅ spack_setup
• ✅ build:intel
• ✅ build:nvhpc
• ✅ test:intel
• ✅ test:nvhpc

[alkino]

@iomaganaris @ohm314

The generated code is verbose.

BEFORE INITIAL {
  init()
  inc = 0
  bi = inc
  bit = t
  printf("ba0 BEFORE INITIAL inc=%g t=%g\n", inc, t)
}

generate:

/** BEFORE of block type INITIAL # 0 */
void nrn_before_after_0_ba0(NrnThread* nt, Memb_list* ml, int type) {
    int nodecount = ml->nodecount;
    int pnodecount = ml->_nodecount_padded;
    const int* node_index = ml->nodeindices;
    double* data = ml->data;
    const double* voltage = nt->_actual_v;
    Datum* indexes = ml->pdata;
    ThreadDatum* thread = ml->_thread;
    auto* const inst = static_cast<ba0_Instance*>(ml->instance);

    #pragma ivdep
    #pragma omp simd
    for (int id = 0; id < nodecount; id++) {
        int node_id = node_index[id];
        double v = voltage[node_id];
        #if NRN_PRCELLSTATE
        inst->v_unused[id] = v;
        #endif
        {
            init_ba0(id, pnodecount, inst, data, indexes, thread, nt, v);
            inst->inc[id] = 0.0;
            inst->bi[id] = inst->inc[id];
            inst->bit[id] = nt->_t;
            printf("ba0 BEFORE INITIAL inc=%g t=%g\n", inst->inc[id], nt->_t);
        }
    }
}

I'm not sure what to test there

[ohm314]

Maybe it's enough to have

BEFORE INITIAL {
  init()
  inc = 0
}

and make sure we find this loop in the output:

#pragma ivdep
#pragma omp simd
for (int id = 0; id < nodecount; id++) {
    int node_id = node_index[id];
    double v = voltage[node_id];
    #if NRN_PRCELLSTATE
    inst->v_unused[id] = v;
    #endif
    {
        init_ba0(id, pnodecount, inst, data, indexes, thread, nt, v);
        inst->inc[id] = 0.0;
    }
}

[pramodk]

👍 thanks!

If CI passes, good to go!

[bbpbuildbot]

Logfiles from GitLab pipeline #94403 (:white_check_mark:) have been uploaded here!

Status and direct links:

• ✅ spack_setup
• ✅ build:intel
• ✅ build:nvhpc
• ✅ test:intel
• ✅ test:nvhpc

[bbpbuildbot]

Logfiles from GitLab pipeline #94618 (:white_check_mark:) have been uploaded here!

Status and direct links:

• ✅ spack_setup
• ✅ build:intel
• ✅ build:nvhpc
• ✅ test:intel
• ✅ test:nvhpc