-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for BEFORE/AFTER block #979
Conversation
@alkino did you see the spack failure on the bbpgitlab CI? Maybe it has something to do with the updated neuron@develop that was mentioned today? I think once this hickup is fixed and maybe the tests are just a little bit expanded we can merge this. |
39c0c98
to
e8559f4
Compare
b32fc9e
to
69a442d
Compare
69a442d
to
28132b9
Compare
Logfiles from GitLab pipeline #93370 (:white_check_mark:) have been uploaded here! Status and direct links: |
The generated code is verbose.
generate: /** BEFORE of block type INITIAL # 0 */
void nrn_before_after_0_ba0(NrnThread* nt, Memb_list* ml, int type) {
int nodecount = ml->nodecount;
int pnodecount = ml->_nodecount_padded;
const int* node_index = ml->nodeindices;
double* data = ml->data;
const double* voltage = nt->_actual_v;
Datum* indexes = ml->pdata;
ThreadDatum* thread = ml->_thread;
auto* const inst = static_cast<ba0_Instance*>(ml->instance);
#pragma ivdep
#pragma omp simd
for (int id = 0; id < nodecount; id++) {
int node_id = node_index[id];
double v = voltage[node_id];
#if NRN_PRCELLSTATE
inst->v_unused[id] = v;
#endif
{
init_ba0(id, pnodecount, inst, data, indexes, thread, nt, v);
inst->inc[id] = 0.0;
inst->bi[id] = inst->inc[id];
inst->bit[id] = nt->_t;
printf("ba0 BEFORE INITIAL inc=%g t=%g\n", inst->inc[id], nt->_t);
}
}
} I'm not sure what to test there |
Maybe it's enough to have
and make sure we find this loop in the output: #pragma ivdep
#pragma omp simd
for (int id = 0; id < nodecount; id++) {
int node_id = node_index[id];
double v = voltage[node_id];
#if NRN_PRCELLSTATE
inst->v_unused[id] = v;
#endif
{
init_ba0(id, pnodecount, inst, data, indexes, thread, nt, v);
inst->inc[id] = 0.0;
}
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 thanks!
If CI passes, good to go!
Logfiles from GitLab pipeline #94403 (:white_check_mark:) have been uploaded here! Status and direct links: |
Logfiles from GitLab pipeline #94618 (:white_check_mark:) have been uploaded here! Status and direct links: |
Should fix #946