Switch Python bindings to pybind11. #57
Conversation
Drop MVD2 support from Python, and keep the interface more in line with Python conventions.
There was a problem hiding this comment.
Looks very nice! Good job.
One little thing though: Python package version comes from Git whereas the C++ library use the hardcoded version in top CMakeLists.txt. I would rather unify this to prevent inconsistencies.
python setup.py --version command outputs the package version. Basalt project uses the output of this command to define the version in CMake (see chunk of code)
I suggest to do something similar here.
| set(MVDTOOL_VERSION_MINOR 5) | ||
| set(MVDTOOL_VERSION_PATCH 2) | ||
| # get version from Python package | ||
| find_package(PythonInterp REQUIRED) |
There was a problem hiding this comment.
check out this instead:
https://github.com/BlueBrain/nmodl/blob/master/cmake/FindPythonModule.cmake
There was a problem hiding this comment.
Looks good, but isn't that for module dependencies? We're trying to get just the version out of setup.py, without requiring any python modules to be installed, really.
Drop MVD2 support from Python, and keep the interface more in line with
Python conventions.