Fix thread-safety statement. #733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pramodk after merging the PR yesterday, I noticed that while the new sentence sounds good. It's likely not true. A user has reported that HighFive isn't thread-safe and provided code comparing HDF5 and HighFive. Given that some HighFive object modify themselves, I thinks plausible that HighFive isn't thread-safe even when using the thread-safe HDF5 library. |
|
Ah ok! Just to have a reference in this ticket, could you add a link to relevant issue / comment? |
|
I think I've seen others, but this one feel credible: #675. |
pramodk
approved these changes
Apr 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.