Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test for several versions of libhdf5 #646

Merged
merged 5 commits into from
Nov 21, 2022
Merged

Test for several versions of libhdf5 #646

merged 5 commits into from
Nov 21, 2022

Conversation

alkino
Copy link
Member

@alkino alkino commented Nov 10, 2022

No description provided.

@alkino alkino marked this pull request as ready for review November 10, 2022 13:08
@alkino alkino force-pushed the cornu/test_hdf5 branch 7 times, most recently from 3ed3428 to 8775b6f Compare November 10, 2022 15:05
git clone https://github.com/HDFGroup/hdf5 --depth 1 --branch ${{ matrix.hdf5_version }}
mkdir -p hdf5/BUILD && cd hdf5/BUILD
cmake .. -GNinja -DCMAKE_INSTALL_PREFIX=$PWD/I -DHDF5_ENABLE_Z_LIB_SUPPORT=ON -DHDF5_ENABLE_SZIP_SUPPORT=ON -DHDF5_ENABLE_SZIP_ENCODING=ON -DUSE_LIBAEC=ON
ninja && ninja install
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just an alternative (that we use in neuron) in case building HDF5 from source would become problematic/too slow: 1) we can keep platform fixed (e.g. ubuntu 22.04) 2) build hdf5 library with system compiler and store the binary artefacts somewhere 3) use those artefacts here in the CI

Downside is we will need to rebuild HDF5 artefacts but that we will need once in a while when we change base OS image (which we don't need to do often).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or, just using one of the binary distribution that they provide with centos7/centos8 platform:
image

Copy link
Contributor

@ohm314 ohm314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to make things more readable.

.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@2766b2f). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #646   +/-   ##
=========================================
  Coverage          ?   79.41%           
=========================================
  Files             ?       66           
  Lines             ?     3697           
  Branches          ?        0           
=========================================
  Hits              ?     2936           
  Misses            ?      761           
  Partials          ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@ohm314 ohm314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@alkino alkino merged commit 79ad222 into master Nov 21, 2022
@alkino alkino deleted the cornu/test_hdf5 branch November 21, 2022 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants