Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code fixes and website improvements #555

Merged
merged 8 commits into from
Apr 8, 2022
Merged

Code fixes and website improvements #555

merged 8 commits into from
Apr 8, 2022

Conversation

ohm314
Copy link
Contributor

@ohm314 ohm314 commented Apr 6, 2022

We push here a few more fixes and additions to finalize the website for the poster.

The version that is currently deployed on gh-pages is here: https://go.epfl.ch/hi5

include/highfive/H5PropertyList.hpp Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Apr 7, 2022

Codecov Report

❗ No coverage uploaded for pull request base (master@da42ec5). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #555   +/-   ##
=========================================
  Coverage          ?   80.97%           
=========================================
  Files             ?       65           
  Lines             ?     3553           
  Branches          ?        0           
=========================================
  Hits              ?     2877           
  Misses            ?      676           
  Partials          ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da42ec5...4d77e8c. Read the comment docs.

matz-e
matz-e previously approved these changes Apr 8, 2022
@ohm314 ohm314 marked this pull request as ready for review April 8, 2022 11:48
matz-e
matz-e previously approved these changes Apr 8, 2022
Omar Awile and others added 7 commits April 8, 2022 13:48
- Fixed all codes to make sure they run on CE.
  Only exception is MPI since there is none on CE. Also, for now boost
  and Eigen must be loaded manually once on CE.
- Made the CE icon a bit bigger and fixed issues with wrong code being
  loaded.
The container class has less spacing, making the Godbolt logo and
whitespace before code look less aligned
Reduced the amount of <div> things, too
The 2 `friend` directive additions in highfive/H5PropertyList.hpp
were required to build doc/poster/example2.cpp with Apple clang version 13.1.6
@ohm314
Copy link
Contributor Author

ohm314 commented Apr 8, 2022

Let's merge this now so it's up to date when submitting poster. We can always add a bit more content later.

matz-e
matz-e previously approved these changes Apr 8, 2022
@ohm314 ohm314 merged commit 53b08b9 into master Apr 8, 2022
@ohm314 ohm314 deleted the poster_final branch April 8, 2022 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants