feat:H105-L3 : Refunds implementation for bambora #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jagan-jaya
suggested changes
Feb 14, 2023
| @@ -519,6 +519,7 @@ pub enum Connector { | |||
| Cybersource, | |||
| #[default] | |||
| Dummy, | |||
| Bambora, | |||
There was a problem hiding this comment.
run cargo clippy --all-features --all-targets && cargo +nightly fmt --all and fix clippy warnings
| @@ -153,6 +153,7 @@ pub struct Connectors { | |||
|
|
|||
| // Keep this field separate from the remaining fields | |||
| pub supported: SupportedConnectors, | |||
| pub bambora: ConnectorParams, | |||
There was a problem hiding this comment.
run cargo clippy --all-features --all-targets && cargo +nightly fmt --all and fix clippy warnings
| pub use self::{ | ||
| aci::Aci, adyen::Adyen, applepay::Applepay, authorizedotnet::Authorizedotnet, | ||
| braintree::Braintree, checkout::Checkout, cybersource::Cybersource, fiserv::Fiserv, | ||
| globalpay::Globalpay, klarna::Klarna, payu::Payu, rapyd::Rapyd, shift4::Shift4, stripe::Stripe, | ||
| worldline::Worldline, worldpay::Worldpay, | ||
| bambora::Bambora, |
There was a problem hiding this comment.
run cargo clippy --all-features --all-targets && cargo +nightly fmt --all and fix clippy warnings
| _req: &types::RouterData<Flow, Request, Response>, | ||
| _connectors: &settings::Connectors, | ||
| ) -> CustomResult<Vec<(String, String)>, errors::ConnectorError> { | ||
| // todo!() |
| } | ||
|
|
||
| fn common_get_content_type(&self) -> &'static str { | ||
| // todo!() |
Comment on lines
+436
to
+438
| // Connector dependent test cases goes here | ||
|
|
||
| // [#478]: add unit tests for non 3DS, wallets & webhooks in connector tests |
| @@ -22,7 +23,7 @@ impl ConnectorAuthentication { | |||
| pub(crate) fn new() -> Self { | |||
| #[allow(clippy::expect_used)] | |||
| toml::from_str( | |||
| &std::fs::read_to_string("tests/connectors/auth.toml") | |||
| &std::fs::read_to_string("tests/connectors/sample_auth.toml") | |||
|
|
||
| [bambora] | ||
| api_key = "MzAwMjEzMTkzOkQwMDIwODkyRjViMjQxZUVhMGIxODA1Rjk5NjgyMGU1" |
Comment on lines
-447
to
452
| card_number: Secret::new("4200000000000000".to_string()), | ||
| card_exp_month: Secret::new("10".to_string()), | ||
| card_exp_year: Secret::new("2025".to_string()), | ||
| card_number: Secret::new("4030000010001234".to_string()), | ||
| card_exp_month: Secret::new("02".to_string()), | ||
| card_exp_year: Secret::new("14".to_string()), | ||
| card_holder_name: Secret::new("John Doe".to_string()), | ||
| card_cvc: Secret::new("999".to_string()), | ||
| card_cvc: Secret::new("123".to_string()), | ||
| }) |
There was a problem hiding this comment.
do not change any value in utils.rs as it is used by default for other connectors
| @@ -84,6 +84,9 @@ base_url = "https://apple-pay-gateway.apple.com/" | |||
| [connectors.klarna] | |||
| base_url = "https://api-na.playground.klarna.com/" | |||
|
|
|||
| [connectors.bambora] | |||
| base_url = | |||
| fn try_from(_item: &types::PaymentsAuthorizeRouterData) -> Result<Self,Self::Error> { | ||
| let card_details:InputCardDetails = match _item.request.payment_method_data { | ||
| api::PaymentMethod::Card(ref ccard) => InputCardDetails{ | ||
| name:ccard.card_holder_name.peek().clone(), |
There was a problem hiding this comment.
Don't peek the Secrets, Instead use Secret for the fields in BamboraPaymentsRequest wherever necessary
ArjunKarthik
suggested changes
Feb 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
Description
Implemented refunds usecase for Bambora gateway, testcases were running in postman.