Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(utils.py): allow passing dynamic api base for openai-compatible endpoints (Fireworks AI, etc.) #4723

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

krrishdholakia
Copy link
Contributor

Title

allow passing dynamic api base for openai-compatible endpoints

Relevant issues

Fixes issue where api_base passed dynamically for openai-compatible endpoints was being ignored

Type

🐛 Bug Fix

Changes

  • checks if api_base is not null before defaulting to provider api base

[REQUIRED] Testing - Attach a screenshot of any new tests passing locall

If UI changes, send a screenshot/GIF of working UI fixes

  • test added for bad api base passed in dynamically for fireworks ai

Copy link

vercel bot commented Jul 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
litellm ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 16, 2024 3:03am

@krrishdholakia krrishdholakia merged commit 74e263b into main Jul 16, 2024
9 of 10 checks passed
@krrishdholakia krrishdholakia deleted the litellm_add_dynamic_api_base branch July 16, 2024 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant