Add token counting for OpenAI tools/tool_choice #4716
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title
This PR implements token counting for OpenAI calls that include tools and tool_choice parameter, based on the approach I use in https://github.com/pamelafox/openai-messages-token-helper
I don't know if any other LLMs support tools/tool_choice at this point, and if so, I don't know how to count tokens for other LLMs yet, so this is OpenAI-specific.
I brought in my test cases that have been verified with OpenAI, and also fixed an issue that I saw with counting tokens for images.
I can also expand on the current documentation to mention tools/tool_choice, if this approach looks good.
Relevant issues
Fixes #4664
Type
🆕 New Feature
🐛 Bug Fix
✅ Test
Changes
[REQUIRED] Testing