Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] new --stop-on-failure option #273

Merged
merged 6 commits into from
Apr 12, 2013

Conversation

muhqu
Copy link
Contributor

@muhqu muhqu commented Apr 11, 2013

I have implemented a --stop-on-failure option. When you run behat --stop-on-failure it will stop after the first failed scenario.

This feature is inspired by phpunit --stop-on-error option.

@muhqu
Copy link
Contributor Author

muhqu commented Apr 11, 2013

Huh... is it really my pull-request that breaks the build on php 5.5?

@muhqu
Copy link
Contributor Author

muhqu commented Apr 11, 2013

just added #274 to fix the failing test

@@ -169,6 +169,19 @@ protected function getCliReturnCode()
}

/**
* Abort Suite on interution or when running in stop-on-failure mode.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo interuption

@stof
Copy link
Member

stof commented Apr 11, 2013

This looks good to me. What do you think about it @everzet ?

@everzet
Copy link
Member

everzet commented Apr 12, 2013

Yep, it looks nice. I've restarted Travis build. If it passes, we can merge this PR.

@everzet
Copy link
Member

everzet commented Apr 12, 2013

Oh, wait. One thing, you've forgot to add new option to behat.yml configuration reader:
https://github.com/Behat/Behat/blob/develop/src/Behat/Behat/DependencyInjection/Configuration/Configuration.php#L99-L119

@muhqu
Copy link
Contributor Author

muhqu commented Apr 12, 2013

@everzet I just added it there, but I don't really know what its there for... I'm not so used to this Symfony DI stuff. Any hint on how to validate its now working as expected?

everzet added a commit that referenced this pull request Apr 12, 2013
[Feature] new --stop-on-failure option
@everzet everzet merged commit 7612d42 into Behat:develop Apr 12, 2013
@joshribakoff
Copy link

I can't find the documentation for adding this option to behat.yml I figure out on my own its like this:

default:
        options:
                stop_on_failure: ~

@Taluu
Copy link
Contributor

Taluu commented Jul 1, 2013

Yup, and also, why put null as a default value for this option, instead of false ?

@stof
Copy link
Member

stof commented Jul 1, 2013

why putting null for a boolean value ?

@Taluu
Copy link
Contributor

Taluu commented Jul 1, 2013

Hum, furthermore, it seems that null is the default value for all the other booleans...

@muhqu
Copy link
Contributor Author

muhqu commented Jul 1, 2013

I just choosed what was used for the other booleans.. :-/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants