This repository has been archived by the owner on Aug 15, 2022. It is now read-only.
Quality of life improvements for use in stand-alone servers #393
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation of #310, as the original author is no longer interested in fixing the changes.
From the original PR:
I've processed some of the feedback on the pull request as well:
ToString
overrides were added for the new types for easy debugging.System.Numeric
types are now used instead of new custom types.UnityNear
was consolidated withNear
as the former already falls back to the latter, but the former doesn't work in stand-alone projects as it depends on Unity, and it was also used in network objects, which was also updated.StandAloneObjectMapper
are now part ofObjectMapper
as these new types don't conflict with the existing types and this prevents new users from being confused, as they would need to callStandAloneObjectMapper.Instance.UseAsDefault();
to get them recognized in network objects.Open questions:
Do we switch fromDone.FloatX
toSystem.Numerics.VectorX
, as suggested by @phalasz?StandAloneObjectMapper
andUnityNear
are gone, we can have a single generated version that works both stand-alone and inside Unity, though dropping the Unity types above would make be required.