Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix too strict rule preventing wp cerber licence activation #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

iazema
Copy link

@iazema iazema commented Nov 21, 2023

No description provided.

Copy link
Member

@petitphp petitphp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Le titre de la PR parle de Cerber, mais la modification concerne wp-rocket.me. C'est voulu ?

@iazema
Copy link
Author

iazema commented Nov 23, 2023

Le titre de la PR parle de Cerber, mais la modification concerne wp-rocket.me. C'est voulu ?

Ah oui c'est parce que je les confonds tout le temps mais c'était bien l'activation de Rocket le souci

@petitphp
Copy link
Member

On fait un check strict sur les domains de la denylist :

if ( $request_host === $blocklist_domain ) {

Du coup, je ne pense pas qu'ajouté un * au début va fonctionner ?

@herewithme
Copy link
Member

herewithme commented Nov 23, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants