Added option to get variations with stock 0 in feed + new query #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jeremykervran Je vois que De notre côté, si la personne à choisis d'avoir toutes les variations même avec un stock à zéro on pourrait utiliser |
Rahe
requested changes
Oct 7, 2022
petitphp
reviewed
Oct 17, 2022
There was a problem hiding this comment.
@jeremykervran Il faudrait qu'on se repose sur la PR pour voir. Je me demande si ça n'ajoute pas un effet de bord l'ajout du paramètre $for_feed.
Rahe
reviewed
Oct 24, 2022
petitphp
reviewed
Jan 9, 2023
petitphp
reviewed
Jan 10, 2023
petitphp
reviewed
Jan 10, 2023
|
TODO: rebase |
petitphp
force-pushed
the
issue/58586
branch
3 times, most recently
from
b8d017c
to
5dfd36e
Compare
petitphp
force-pushed
the
issue/58586
branch
2 times, most recently
from
19dc228
to
56626f9
Compare
petitphp
force-pushed
the
issue/58586
branch
2 times, most recently
from
413fc14
to
bc6d93d
Compare
Ensure out of stock products (simple and variation) are not included in the feed by default. Rework the new option to control both simple and variations products in the feed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Je pense qu'on a pas d'autre choix que de faire une query custom pour gérer les variations à stock 0 dans le flux, à cause du fonctionnement de base de WC qui base tout sur une option : https://woocommerce.github.io/code-reference/files/woocommerce-includes-class-wc-product-variable.html#source-view.302
Modifier cette option à la volée entrainerait trop d'effets de bords possibles.
Y'a potentiellement mieux que la WP_Query que je fais dans get_all_product_variations( $product ) - src/Products/Product.php ligne 454, en passant par une WC_Query peut-être ?
Mais en l'état ça marche :
21 0 // STOCK A ZERO QUI REMONTE 10.00 8.00 variation-1