-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate from Travis to Azure #116
Conversation
@@ -9,3 +9,4 @@ pytest-mock==1.10.0 | |||
coveralls==1.5.1 | |||
pytest-cov==2.6.1 | |||
py-mini-racer==0.1.18 | |||
attrs==19.1.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To fix
[command]/bin/bash --noprofile --norc /home/vsts/work/_temp/8eb70c1f-fd00-43a7-bea0-aa872dac2bfe.sh
Traceback (most recent call last):
File "/opt/hostedtoolcache/Python/3.5.7/x64/bin/pytest", line 10, in <module>
sys.exit(main())
File "/opt/hostedtoolcache/Python/3.5.7/x64/lib/python3.5/site-packages/_pytest/config/__init__.py", line 61, in main
config = _prepareconfig(args, plugins)
File "/opt/hostedtoolcache/Python/3.5.7/x64/lib/python3.5/site-packages/_pytest/config/__init__.py", line 182, in _prepareconfig
config = get_config()
File "/opt/hostedtoolcache/Python/3.5.7/x64/lib/python3.5/site-packages/_pytest/config/__init__.py", line 156, in get_config
pluginmanager.import_plugin(spec)
File "/opt/hostedtoolcache/Python/3.5.7/x64/lib/python3.5/site-packages/_pytest/config/__init__.py", line 530, in import_plugin
__import__(importspec)
File "/opt/hostedtoolcache/Python/3.5.7/x64/lib/python3.5/site-packages/_pytest/tmpdir.py", line 25, in <module>
class TempPathFactory(object):
File "/opt/hostedtoolcache/Python/3.5.7/x64/lib/python3.5/site-packages/_pytest/tmpdir.py", line 35, in TempPathFactory
lambda p: Path(os.path.abspath(six.text_type(p)))
TypeError: attrib() got an unexpected keyword argument 'convert'
error.
Refer to pytest-dev/pytest#3280 (comment).
# - script: coveralls | ||
# displayName: Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be configured manually (with token):
[command]/bin/bash --noprofile --norc /home/vsts/work/_temp/3e5c0a43-effc-4bd1-9192-d036a83503e2.sh
Not on Travis or CircleCI. You have to provide either repo_token in .coveralls.yml or set the COVERALLS_REPO_TOKEN env var.
Traceback (most recent call last):
File "/opt/hostedtoolcache/Python/3.5.7/x64/lib/python3.5/site-packages/coveralls/cli.py", line 60, in main
service_name=options['--service'])
File "/opt/hostedtoolcache/Python/3.5.7/x64/lib/python3.5/site-packages/coveralls/api.py", line 59, in __init__
self.ensure_token()
File "/opt/hostedtoolcache/Python/3.5.7/x64/lib/python3.5/site-packages/coveralls/api.py", line 68, in ensure_token
self.config_filename))
coveralls.exception.CoverallsException: Not on Travis or CircleCI. You have to provide either repo_token in .coveralls.yml or set the COVERALLS_REPO_TOKEN env var.
I think migrating to Azure should be considered as a last resort when there's literally no way to fix the original problem. To me it doesn't seem to be the case, at least for now. As I mentioned in this comment #114 (comment), sometimes we need an ability to run e2e tests locally, and I don't think we should have e2e tests running for more than 50 minutes. Before making this change I would kindly ask you to investigate what exactly takes so much time. You could start by looking into single model and comparing it to other languages. And thanks for your constant initiative to make m2cgen better, we really appreciate your effort! |
Unfortunately, I can only confirm that PowerShell is quite slow. Tests for all models run significant amount of time, and there is no "one test that takes the most time of 50 minutes". I guess it's specific to PowerShell and nothing can be done with it. |
OK, I think I'd better close this PR for now. Anyway, you can take my proposed config from the |
Refer to #114 (comment).
Results can be observed here: https://dev.azure.com/nekit94-120479/nekit94-12/_build/results?buildId=6.
List of installed software on
ubuntu-16.04
: https://github.com/Microsoft/azure-pipelines-image-generation/blob/master/images/linux/Ubuntu1604-README.md.The only thing in needed to do is register Azure account (if not yet), create a public project and link it to this repo.
ping @krinart @izeigerman