Fix flipped One Shot logic (qmk#16617)

Bastardkb · Jul 2, 2022 · cdfb557 · cdfb557
1 parent ceaf5a6
commit cdfb557
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/quantum/action_util.c b/quantum/action_util.c
@@ -187,8 +187,9 @@ bool is_oneshot_layer_active(void) {
  * FIXME: needs doc
  */
 void oneshot_set(bool active) {
- if (keymap_config.oneshot_disable != active) {
- keymap_config.oneshot_disable = active;
+ const bool disable = !active;
+ if (keymap_config.oneshot_disable != disable) {
+ keymap_config.oneshot_disable = disable;
  eeconfig_update_keymap(keymap_config.raw);
  clear_oneshot_layer_state(ONESHOT_OTHER_KEY_PRESSED);
  dprintf("Oneshot: active: %d\n", active);
@@ -220,7 +221,7 @@ void oneshot_disable(void) {
 }
 
 bool is_oneshot_enabled(void) {
- return keymap_config.oneshot_disable;
+ return !keymap_config.oneshot_disable;
 }
 
 #endif