Adds support for when in use only. #1295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| [_locationManager requestAlwaysAuthorization]; | ||
| } else if ([[NSBundle mainBundle] objectForInfoDictionaryKey:@"NSLocationWhenInUseUsageDescription"] != nil) { | ||
| [_locationManager requestWhenInUseAuthorization]; | ||
| } else { | ||
| [[NSException exceptionWithName:NSInternalInconsistencyException reason:@"To use location in iOS8 you need to define either NSLocationWhenInUseUsageDescription or NSLocationAlwaysUsageDescription in the app bundle's Info.plist file" userInfo:nil] raise]; | ||
| errorHandler(@"MISSING_USAGE_DESCRIPTION", @"To use location in iOS8 you need to define at least NSLocationWhenInUseUsageDescription and optionally NSLocationAlwaysAndWhenInUseUsageDescription in the app bundle's Info.plist file"); |
There was a problem hiding this comment.
Is this in iOS 8 or from iOS 8?
There was a problem hiding this comment.
Good comment, it should be "from" and I have pushed an update.
| } else if (permission == PermissionGroupLocationAlways) { | ||
| if ([[NSBundle mainBundle] objectForInfoDictionaryKey:@"NSLocationAlwaysUsageDescription"] != nil) { | ||
| #if PERMISSION_LOCATION |
There was a problem hiding this comment.
is this PERMISSION_LOCATION correct?
There was a problem hiding this comment.
Yes that is correct. The existing PERMISSION_LOCATION macro enables "when in use" and "always" permissions. I didn't want to rename it as that would be a breaking change.
Co-authored-by: TimHoogstrate <[email protected]>
Co-authored-by: TimHoogstrate <[email protected]>
…w/flutter-permission-handler into fine_grained_location_permission
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PERMISSION_LOCATION_WHENINUSEmarco, which can be used instead ofthe
PERMISSION_LOCATIONmacro and only enable therequestWhenInUseAuthorizationand remove the
requestAlwaysAuthorizationwhen requesting location permission.Info.plistdoesn't contain the correct declarations.NSLocationAlwaysAndWhenInUseUsageDescriptionproperty listkey.
Pre-launch Checklist
pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is does not need version changes.CHANGELOG.mdto add a description of the change.///).main.dart format .and committed any changes.flutter analyzeand fixed any errors.