Added a new feature to receive NMEA messages #605

Sempakonka · 2020-11-24T09:32:23Z

✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)

This PR introduces a new feature.

⤵️ What is the current behavior?

Currently you can not receive NMEA messages.

🆕 What is the new behavior (if this is a feature change)?

With this PR, you are able to recieve NMEA mesages

Example

StreamSubscription<NmeaMessage> nmeaStream = getNmeaStream()
    .listen((NmeaMessage nmea) {
      // Handle NMEA changes
    });

This stream will continually give NMEA updates

💥 Does this PR introduce a breaking change?

No

🐛 Recommendations for testing

Use the example app ;)

📝 Links to relevant issues/docs

fixes #561

🤔 Checklist before submitting

All projects build
Follows style guide lines (code style guide)
Relevant documentation was updated
Rebased onto current develop

codecov · 2020-11-24T11:30:34Z

Codecov Report

Merging #605 (818653f) into master (9dc3f8d) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##            master      #605    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           15         1    -14     
  Lines          258        43   -215     
==========================================
- Hits           258        43   -215

Impacted Files	Coverage Δ
geolocator/lib/geolocator.dart	`100.00% <100.00%> (ø)`
...terface/lib/src/extensions/integer_extensions.dart
...orm_interface/lib/src/models/location_options.dart
...or_platform_interface/lib/src/models/position.dart
...e/lib/src/errors/invalid_permission_exception.dart
...rc/errors/location_service_disabled_exception.dart
...ce/lib/src/errors/permission_denied_exception.dart
...m_interface/lib/src/enums/location_permission.dart
...face/lib/src/errors/position_update_exception.dart
...e/lib/src/errors/already_subscribed_exception.dart
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9dc3f8d...818653f. Read the comment docs.

mvanbeusekom · 2020-11-25T07:53:37Z

geolocator/android/src/main/AndroidManifest.xml

@@ -1,3 +1,5 @@
 <manifest xmlns:android="https://schemas.android.com/apk/res/android"
  package="com.baseflow.geolocator">
+
+  <uses-permission android:name="android.permission.ACCESS_FINE_LOCATION" />


This line should be removed. It will probably give a warning which can be suppressed in code.

Permissions are the responsibility of the developers using the plugin in their App and should not be something we determine for them.

Suggested change

<uses-permission android:name="android.permission.ACCESS_FINE_LOCATION" />

mvanbeusekom · 2020-11-25T07:56:06Z

geolocator/android/src/main/java/com/baseflow/geolocator/GeolocatorPlugin.java

@@ -21,11 +21,17 @@

  @Nullable private MethodCallHandlerImpl methodCallHandler;

-  @Nullable private StreamHandlerImpl streamHandler;
+  @Nullable
+  private PositionStreamImpl streamHandler;


I see you renamed the class StreamHandlerImpl to PositionStreamImpl, this name however suggests that the class is a stream dealing with positions. This is however not the case, the class implements all the logic necessary to create a stream but it is not the stream it self. So I suggest we rename it to PositionStreamHandlerImpl.

Also it would be nice to rename the variable streamHandler to positionStreamHandler making it a bit more semantic and easier to read code for other developers.

Suggested change

private PositionStreamImpl streamHandler;

private PositionStreamHandlerImpl positionStreamHandler;

mvanbeusekom · 2020-11-25T07:58:13Z

geolocator/android/src/main/java/com/baseflow/geolocator/GeolocatorPlugin.java


-  @Nullable private Registrar pluginRegistrar;
+  @Nullable
+  private NmeaStreamImpl nmeaStream;


Same as the above PositionStreamImpl. It would be better to rename this to:

Suggested change

private NmeaStreamImpl nmeaStream;

private NmeaStreamHandlerImpl nmeaStreamHandler;

mvanbeusekom · 2020-11-25T08:09:47Z

geolocator/android/src/main/java/com/baseflow/geolocator/NmeaStreamImpl.java

+    this.geolocationManager = geolocationManager;
+  }
+
+  public static Map<String, Object> toMap(String n, Long l) {


This method should be made private.

It's intention is to convert the NMEA result into a format that the Flutter EventChannel understands. Only the NmeaStreamHandlerImpl (after you renamed the class) is allowed to send messages on the NMEA EventChannel, meaning other code should be protected from knowing how to map a NMEA object to a map.

Suggested change

public static Map<String, Object> toMap(String n, Long l) {

private static Map<String, Object> toMap(String n, Long l) {

mvanbeusekom · 2020-11-25T08:38:00Z

geolocator/android/src/main/java/com/baseflow/geolocator/location/GeolocationManager.java

+  public void startNmeaUpdates(Context context, Activity activity, NmeaMessageaClient client,
+      NmeaChangedCallback nmeaChangedCallback, ErrorCallback errorCallback) {
+
+    handlePermissions(
+        context,
+        activity,
+        () -> client.startNmeaUpdates(nmeaChangedCallback, errorCallback),
+        errorCallback);
+  }
+
+  public void stopNmeaUpdates(NmeaMessageaClient client) {
+    client.stopNmeaUpdates();
+  }
+
+  public NmeaMessageaClient createNmeaClient(Context context) {
+    return android.os.Build.VERSION.SDK_INT >= VERSION_CODES.N ? new GnssNmeaMessageClient(context)
+        : new GpsNmeaMessageClient(context);
+  }


It would be better to create a whole new class (in it's own sub folder, together with the NmeaMessageaClient, GnssNmeaMessageClient and GpsNmeaMessageClient classes) NmeaManager and put this logic there. It is not really related to location information and currently bloats the GeolocationManager class making it harder to understand what is going on in the GeolocationManager class.

The current implementation violates the Single-responsibility principle which says (more info here):

A class should have one and only one reason to change, meaning that a class should have only one job.

Currently this class has two reasons two change:

When the implementation of requesting location information changes;

When the implementation of requesting NMEA information changes.

I think it would be good to move the handlePermissions method into the PermissionManager class (and make it public). This way we don't have to duplicate this code in the GeolocationManager and NmeaManager class and we also don't need a reference from the NmeaManager class to the GeolocationManager class.

mvanbeusekom · 2020-11-25T12:46:40Z

geolocator_platform_interface/lib/src/implementations/method_channel_geolocator.dart

+      return _nmeaMessageStream;
+    }
+
+    var nmeaStream = nmeaChannel.receiveBroadcastStream();


The nmeaStream variable can be made final, once it is initialized it does not change (and is should not change), by making it a final variable we can protect against this.

Suggested change

var nmeaStream = nmeaChannel.receiveBroadcastStream();

final nmeaStream = nmeaChannel.receiveBroadcastStream();

mvanbeusekom · 2020-11-25T12:52:38Z

geolocator_platform_interface/lib/src/models/nmea_message.dart

+
+@immutable
+
+///nmea message


Comments should be written as sentences (see here and here for more details). You can also have a look at the Position class for inspiration.

mvanbeusekom · 2020-11-25T12:52:56Z

geolocator_platform_interface/lib/src/models/nmea_message.dart

+
+///nmea message
+class NmeaMessage {
+  ///nmea message


Comments should be written as sentences (see here and here for more details). You can also have a look at the Position class for inspiration.

mvanbeusekom · 2020-11-25T12:53:01Z

geolocator_platform_interface/lib/src/models/nmea_message.dart

+  ///nmea message
+  NmeaMessage(this.message, this.timestamp);
+
+  ///message


Comments should be written as sentences (see here and here for more details). You can also have a look at the Position class for inspiration.

mvanbeusekom · 2020-11-25T12:53:08Z

geolocator_platform_interface/lib/src/models/nmea_message.dart

+  ///message
+  final String message;
+
+  ///timestamp


Comments should be written as sentences (see here and here for more details). You can also have a look at the Position class for inspiration.

mvanbeusekom · 2020-11-25T16:13:56Z

geolocator/lib/geolocator.dart

+  /// StreamSubscription<NmeaMessage> nmeaStream = getNmeaStream()
+  ///     .listen((NmeaMessage nmea) {
+  ///       // Handle NMEA changes
+  ///     });


Code example should include static class:

Suggested change

/// StreamSubscription<NmeaMessage> nmeaStream = getNmeaStream()

/// .listen((NmeaMessage nmea) {

/// // Handle NMEA changes

/// });

/// StreamSubscription<NmeaMessage> nmeaStream = Geolocator.getNmeaStream()

/// .listen((NmeaMessage nmea) {

/// // Handle NMEA changes

/// });

mvanbeusekom

Thank you for updating your PR. I think the code now looks good but still have some minor requests that should be fixed.

mvanbeusekom · 2020-11-26T16:45:31Z

geolocator/android/src/main/java/com/baseflow/geolocator/GeolocatorPlugin.java

-    StreamHandlerImpl streamHandler = new StreamHandlerImpl(geolocatorPlugin.geolocationManager);
+    PositionStreamHandlerImpl streamHandler = new PositionStreamHandlerImpl(geolocatorPlugin.geolocationManager);
    streamHandler.startListening(registrar.context(), registrar.messenger());
    streamHandler.setActivity(registrar.activity());
+
+    NmeaStreamHandlerImpl nmeaStream = new NmeaStreamHandlerImpl(geolocatorPlugin.nmeaMessageManager);
+    nmeaStream.startListening(registrar.context(), registrar.messenger());
+    nmeaStream.setActivity(registrar.activity());
  }

  @Override
  public void onAttachedToEngine(@NonNull FlutterPluginBinding flutterPluginBinding) {
    methodCallHandler = new MethodCallHandlerImpl(this.permissionManager, this.geolocationManager);
    methodCallHandler.startListening(
        flutterPluginBinding.getApplicationContext(), flutterPluginBinding.getBinaryMessenger());
-    streamHandler = new StreamHandlerImpl(this.geolocationManager);
-    streamHandler.startListening(
+    positionStreamHandler = new PositionStreamHandlerImpl(this.geolocationManager);
+    positionStreamHandler.startListening(
+        flutterPluginBinding.getApplicationContext(), flutterPluginBinding.getBinaryMessenger());
+    nmeaStreamHandler = new NmeaStreamHandlerImpl(this.nmeaMessageManager);
+    nmeaStreamHandler.startListening(
        flutterPluginBinding.getApplicationContext(), flutterPluginBinding.getBinaryMessenger());
  }


I think it is time to simplify this block of code and do some more code sharing. I think we can replace the registerWith, onAttachedToEngine and onAttachedToActivity with the following methods:

Improved registerWith

// This static function is optional and equivalent to onAttachedToEngine. It supports the old // pre-Flutter-1.12 Android projects. You are encouraged to continue supporting // plugin registration via this function while apps migrate to use the new Android APIs // post-flutter-1.12 via https://flutter.dev/go/android-project-migration. // // It is encouraged to share logic between onAttachedToEngine and registerWith to keep // them functionally equivalent. Only one of onAttachedToEngine or registerWith will be called // depending on the user's project. onAttachedToEngine or registerWith must both be defined // in the same class. public static void registerWith(Registrar registrar) { GeolocatorPlugin geolocatorPlugin = new GeolocatorPlugin(); geolocatorPlugin.pluginRegistrar = registrar; geolocatorPlugin.configureListeners(registrar.context(), registrar.messenger()); geolocatorPlugin.setActivity(registrar.activity()); }

Improved onAttachedToEngine

@Override public void onAttachedToEngine(@NonNull FlutterPluginBinding flutterPluginBinding) { configureListeners(flutterPluginBinding.getApplicationContext(), flutterPluginBinding.getBinaryMessenger()); }

Improved onAttachedToActivity

@Override public void onAttachedToActivity(@NonNull ActivityPluginBinding binding) { this.pluginBinding = binding; setActivity(binding.getActivity()); }

Improved onDetachedFromActivity

@Override public void onDetachedFromActivity() { setActivity(null); }

New method configureListeners

void configureListeners(Context applicationContext, BinaryMessenger messenger) { methodCallHandler = new MethodCallHandlerImpl(permissionManager, geolocationManager); methodCallHandler.startListening(applicationContext, messenger); positionStreamHandler = new PositionStreamHandlerImpl(geolocationManager); positionStreamHandler.startListening(applicationContext, messenger); nmeaStreamHandler = new NmeaStreamHandlerImpl(nmeaMessageManager); nmeaStreamHandler.startListening(applicationContext, messenger); }

New method setActivity

void setActivity(@Nullable Activity activity) { if (methodCallHandler != null) { methodCallHandler.setActivity(activity); } if (positionStreamHandler != null) { positionStreamHandler.setActivity(activity); } if (nmeaStreamHandler != null) { nmeaStreamHandler.setActivity(activity); } if (activity != null) { registerListeners(); } else { deregisterListeners(); } }

This will remove some duplicated code and also solves confusion with variable names.

mvanbeusekom · 2020-11-26T16:55:50Z

geolocator/android/src/main/java/com/baseflow/geolocator/NmeaStreamHandlerImpl.java

+
+class NmeaStreamHandlerImpl implements EventChannel.StreamHandler {
+
+  private static final String TAG = "NmeaStreamImpl";


Rename TAG to match class name:

Suggested change

private static final String TAG = "NmeaStreamImpl";

private static final String TAG = "NmeaStreamHandlerImpl";

mvanbeusekom · 2020-11-26T16:58:11Z

geolocator/android/src/main/java/com/baseflow/geolocator/NmeaStreamHandlerImpl.java

+    this.nmeaMessageManager = nmeaMessageManager;
+  }
+
+  private static Map<String, Object> toMap(String n, Long l) {


Provide clear self-explanatory variable names instead of using single characters:

Suggested change

private static Map<String, Object> toMap(String n, Long l) {

private static Map<String, Object> toMap(String message, long timestamp) {

mvanbeusekom · 2020-11-26T16:59:59Z

geolocator/android/src/main/java/com/baseflow/geolocator/NmeaStreamHandlerImpl.java

+      return null;
+    }
+
+    Map<String, Object> Nmea = new HashMap<>();


Local variables should not start with a capital:

Suggested change

Map<String, Object> Nmea = new HashMap<>();

Map<String, Object> nmeaMap = new HashMap<>();

mvanbeusekom · 2020-11-26T17:04:22Z

geolocator/android/src/main/java/com/baseflow/geolocator/NmeaStreamHandlerImpl.java

+        context,
+        activity,
+        this.nmeaMessageaClient,
+        (String n, long l) -> events.success(toMap(n, l)),


Provide clear self-explanatory variable name instead of a single character:

Suggested change

(String n, long l) -> events.success(toMap(n, l)),

(String message, long timestamp) -> events.success(toMap(message, timestamp)),

mvanbeusekom · 2020-11-26T17:27:09Z

geolocator/android/src/main/java/com/baseflow/geolocator/nmea/GnssNmeaMessageClient.java

+
+  @SuppressLint("MissingPermission")
+  @Override
+  public void onProviderDisabled(String s) {


Provide self-explanatory variable names instead of single character variable names:

Suggested change

public void onProviderDisabled(String s) {

public void onProviderDisabled(String provider) {

mvanbeusekom · 2020-11-26T17:28:40Z

geolocator/android/src/main/java/com/baseflow/geolocator/nmea/NmeaMessageManager.java

+    return android.os.Build.VERSION.SDK_INT >= VERSION_CODES.N ? new GnssNmeaMessageClient(context)
+        : new GpsNmeaMessageClient(context);


nit: formatting can be little bit improved:

Suggested change

return android.os.Build.VERSION.SDK_INT >= VERSION_CODES.N ? new GnssNmeaMessageClient(context)

: new GpsNmeaMessageClient(context);

return android.os.Build.VERSION.SDK_INT >= VERSION_CODES.N

? new GnssNmeaMessageClient(context)

: new GpsNmeaMessageClient(context);

mvanbeusekom · 2020-11-26T17:32:53Z

geolocator/lib/geolocator.dart

+  /// Returns a stream emitting NMEA-0183 sentences when they are received from
+  /// the GNSS engine. With devices running a Android API level lower than 24
+  /// NMEA-0183 sentences are received from the GPS engine.


nit: the explanation is very clean but Dart documentation guidelines prescribe the first sentence to be short and compact. So maybe we can update this to:

Suggested change

/// Returns a stream emitting NMEA-0183 sentences when they are received from

/// the GNSS engine. With devices running a Android API level lower than 24

/// NMEA-0183 sentences are received from the GPS engine.

/// Returns a stream emitting NMEA-0183 sentences (Android only, no-op on iOS).

///

/// With devices running a Android API level lower than 24 NMEA-0183 sentences

/// are received from the GPS engine. From API level 24 and up the GNSS engine

/// is used.

mvanbeusekom · 2020-11-26T17:33:50Z

geolocator_platform_interface/lib/src/geolocator_platform_interface.dart

+  /// Returns a stream emitting NMEA-0183 sentences when they are received from
+  /// the GNSS engine. With devices running a Android API level lower than 24
+  /// NMEA-0183 sentences are received from the GPS engine.


nit: the explanation is very clean but Dart documentation guidelines prescribe the first sentence to be short and compact. So maybe we can update this to:

Suggested change

/// Returns a stream emitting NMEA-0183 sentences when they are received from

/// the GNSS engine. With devices running a Android API level lower than 24

/// NMEA-0183 sentences are received from the GPS engine.

/// Returns a stream emitting NMEA-0183 sentences (Android only, no-op on iOS).

///

/// With devices running a Android API level lower than 24 NMEA-0183 sentences

/// are received from the GPS engine. From API level 24 and up the GNSS engine

/// is used.

mvanbeusekom · 2020-11-26T17:35:46Z

geolocator_platform_interface/lib/src/implementations/method_channel_geolocator.dart

  EventChannel eventChannel =
      EventChannel('flutter.baseflow.com/geolocator_updates');

+  /// The event channel used to receive [NmeaMessage] updates from the native
+  /// platform.
+  @visibleForTesting
+  EventChannel nmeaChannel = EventChannel('flutter.baseflow.com/nmea_updates');


Similar to the implementation on the JAVA side, I think here we should also use clear naming to differentiate between the event channel broadcasting positions and the event channel broadcasting NMEA messages:

Suggested change

EventChannel eventChannel =

EventChannel('flutter.baseflow.com/geolocator_updates');

/// The event channel used to receive [NmeaMessage] updates from the native

/// platform.

@visibleForTesting

EventChannel nmeaChannel = EventChannel('flutter.baseflow.com/nmea_updates');

EventChannel positionEventChannel =

EventChannel('flutter.baseflow.com/geolocator_updates');

/// The event channel used to receive [NmeaMessage] updates from the native

/// platform.

@visibleForTesting

EventChannel nmeaEventChannel = EventChannel('flutter.baseflow.com/nmea_updates');

…d under Marshmellow

…functionality to example app

…failed

…d tests to increase code coverage to 100%.

Fix: issue #610 - requestPermission does not returning for Android 5.1 and below.

…functionality to example app

…failed

…d tests to increase code coverage to 100%.

version bump

…to issue#516 � Conflicts: � geolocator/CHANGELOG.md � geolocator/README.md � geolocator/example/lib/main.dart � geolocator/pubspec.yaml � geolocator_platform_interface/CHANGELOG.md

parcodepie · 2021-11-12T13:36:46Z

Any news about this feature please? is it ready to be used in Flutter?

Sempakonka changed the title ~~Issue#516~~ Added a new feature to receive NMEA messages Nov 24, 2020

mvanbeusekom requested changes Nov 25, 2020

View reviewed changes

Sempakonka force-pushed the issue#516 branch from 0dad5da to efe1501 Compare November 26, 2020 14:27

mvanbeusekom requested changes Nov 26, 2020

View reviewed changes

danilocubos and others added 10 commits November 28, 2020 21:50

fix: return LocationPermission.always for requestPermission on Androi…

e46ddf9

…d under Marshmellow

fix: result callback

f8c4be4

push voor daniel

9f3db18

nmea message clients both for gps and gnss added. Added nmea message …

6c787cf

…functionality to example app

nmea message clients both for gps and gnss added. Added nmea message …

dfce813

…functionality to example app

nmea message clients both for gps and gnss added. Added nmea message …

10fa655

…functionality to example app

fixed prefer_relative_imports and fixed pubspec.yaml version solving …

6a88988

…failed

fixed platform_interface unit test error

103bbf8

Implemented requested changes as well as improved documentation. Adde…

cb1aaf8

…d tests to increase code coverage to 100%.

Implemented requested changes.

6c5ca1a

Sempakonka force-pushed the issue#516 branch from efe1501 to 6c5ca1a Compare November 30, 2020 15:27

Sempakonka and others added 13 commits November 30, 2020 16:41

fix formatting

7db55c2

Merge pull request #611 from daniloapr/master

6f4f493

Fix: issue #610 - requestPermission does not returning for Android 5.1 and below.

Prepare for version 6.1.9

8203eb6

Add unit-test to verify timeInterval parameter

633de46

push voor daniel

ed9b67c

nmea message clients both for gps and gnss added. Added nmea message …

8dfcb37

…functionality to example app

nmea message clients both for gps and gnss added. Added nmea message …

a1bbbbe

…functionality to example app

nmea message clients both for gps and gnss added. Added nmea message …

d77aa1b

…functionality to example app

fixed prefer_relative_imports and fixed pubspec.yaml version solving …

fc1984a

…failed

fixed platform_interface unit test error

102198d

Implemented requested changes as well as improved documentation. Adde…

38acda5

…d tests to increase code coverage to 100%.

Implemented requested changes.

7b390b8

fix formatting

723a78b

Sempakonka and others added 5 commits December 1, 2020 12:00

Improved naming of variables in example app

11d7b02

version bump

Add unit-test to verify timeInterval parameter

982053c

Merge branch 'issue#516' of github.com:Baseflow/flutter-geolocator in…

3ba9250

…to issue#516 � Conflicts: � geolocator/CHANGELOG.md � geolocator/README.md � geolocator/example/lib/main.dart � geolocator/pubspec.yaml � geolocator_platform_interface/CHANGELOG.md

version bumb

8a88f54

CI test error fix

818653f

juanmanjarres mentioned this pull request Aug 23, 2021

Add NMEA receiving feature (null safety update) #819

Closed

6 tasks

rickcasson mentioned this pull request Jan 6, 2022

NMEA Messages on Android #932

Open

6 tasks

Wackymax mentioned this pull request Apr 11, 2022

Adds MSL Altitude Support #1029

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added a new feature to receive NMEA messages #605

Added a new feature to receive NMEA messages #605

Sempakonka commented Nov 24, 2020 •

edited by florissmit1

Loading

codecov bot commented Nov 24, 2020 •

edited

Loading

mvanbeusekom Nov 25, 2020

mvanbeusekom Nov 25, 2020

mvanbeusekom Nov 25, 2020

mvanbeusekom Nov 25, 2020

mvanbeusekom Nov 25, 2020

mvanbeusekom Nov 25, 2020

mvanbeusekom Nov 25, 2020

mvanbeusekom Nov 25, 2020

mvanbeusekom Nov 25, 2020

mvanbeusekom Nov 25, 2020

mvanbeusekom Nov 25, 2020

mvanbeusekom left a comment

mvanbeusekom Nov 26, 2020 •

edited

Loading

mvanbeusekom Nov 26, 2020

mvanbeusekom Nov 26, 2020

mvanbeusekom Nov 26, 2020

mvanbeusekom Nov 26, 2020

mvanbeusekom Nov 26, 2020

mvanbeusekom Nov 26, 2020

mvanbeusekom Nov 26, 2020

mvanbeusekom Nov 26, 2020

mvanbeusekom Nov 26, 2020

parcodepie commented Nov 12, 2021

	private PositionStreamImpl streamHandler;
	private PositionStreamHandlerImpl positionStreamHandler;

	private NmeaStreamImpl nmeaStream;
	private NmeaStreamHandlerImpl nmeaStreamHandler;

	public static Map<String, Object> toMap(String n, Long l) {
	private static Map<String, Object> toMap(String n, Long l) {

	var nmeaStream = nmeaChannel.receiveBroadcastStream();
	final nmeaStream = nmeaChannel.receiveBroadcastStream();


		class NmeaStreamHandlerImpl implements EventChannel.StreamHandler {

		private static final String TAG = "NmeaStreamImpl";

	Map<String, Object> Nmea = new HashMap<>();
	Map<String, Object> nmeaMap = new HashMap<>();

	(String n, long l) -> events.success(toMap(n, l)),
	(String message, long timestamp) -> events.success(toMap(message, timestamp)),

	public void onProviderDisabled(String s) {
	public void onProviderDisabled(String provider) {

		return android.os.Build.VERSION.SDK_INT >= VERSION_CODES.N ? new GnssNmeaMessageClient(context)
		: new GpsNmeaMessageClient(context);

-  /// Returns a stream emitting NMEA-0183 sentences when they are received from
-  /// the GNSS engine. With devices running a Android API level lower than 24
-  /// NMEA-0183 sentences are received from the GPS engine.
+  /// Returns a stream emitting NMEA-0183 sentences (Android only, no-op on iOS).
+  ///
+  /// With devices running a Android API level lower than 24 NMEA-0183 sentences
+  /// are received from the GPS engine. From API level 24 and up the GNSS engine
+  /// is used.

Added a new feature to receive NMEA messages #605

Are you sure you want to change the base?

Added a new feature to receive NMEA messages #605

Conversation

Sempakonka commented Nov 24, 2020 • edited by florissmit1 Loading

✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)

⤵️ What is the current behavior?

🆕 What is the new behavior (if this is a feature change)?

💥 Does this PR introduce a breaking change?

🐛 Recommendations for testing

📝 Links to relevant issues/docs

🤔 Checklist before submitting

codecov bot commented Nov 24, 2020 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mvanbeusekom left a comment

Choose a reason for hiding this comment

mvanbeusekom Nov 26, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

parcodepie commented Nov 12, 2021

Sempakonka commented Nov 24, 2020 •

edited by florissmit1

Loading

codecov bot commented Nov 24, 2020 •

edited

Loading

mvanbeusekom Nov 26, 2020 •

edited

Loading