Enable OTA updates for firmware through App #531
+584
−76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josancamon19
requested changes
Aug 8, 2024
| @@ -0,0 +1,67 @@ | |||
| import os | |||
There was a problem hiding this comment.
rename to "firmware.py
| @@ -0,0 +1,137 @@ | |||
| import 'package:flutter/material.dart'; | |||
There was a problem hiding this comment.
Did you test this with the compiled android and ios versions? I've found issues before with the nrf library
| @@ -0,0 +1,157 @@ | |||
| import 'dart:convert'; | |||
There was a problem hiding this comment.
How bad is it if during update, people turn off their devices, or kill the app in the middle of it, can it recover?
| @@ -20,6 +20,7 @@ | |||
| 42127D9B2C283C310005AB40 /* OneSignalExtension.xcframework in Frameworks */ = {isa = PBXBuildFile; fileRef = 42127D9A2C283C310005AB40 /* OneSignalExtension.xcframework */; }; | |||
| 42127D9E2C283C400005AB40 /* OneSignalOSCore.xcframework in Frameworks */ = {isa = PBXBuildFile; fileRef = 42127D9D2C283C400005AB40 /* OneSignalOSCore.xcframework */; }; | |||
| 42127DA12C283C4E0005AB40 /* OneSignalOutcomes.xcframework in Frameworks */ = {isa = PBXBuildFile; fileRef = 42127DA02C283C4E0005AB40 /* OneSignalOutcomes.xcframework */; }; | |||
| 42476A842C5E36DA00426330 /* libsqlite3.tbd in Frameworks */ = {isa = PBXBuildFile; fileRef = 42476A832C5E369200426330 /* libsqlite3.tbd */; }; | |||
There was a problem hiding this comment.
What are this changes for?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #505