-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Custom Audio Player [#381] #399
base: main
Are you sure you want to change the base?
Conversation
Hi @SHAH-JI please upload a video showing the functionality please. Also, if it's initial implementation, created instead a Draft PR. Thanks |
to @josancamon19 |
It looks good in terms of functionality, not in terms of UI. @SHAH-JI |
to @josancamon19 Can you share the UI part which needs improvement? |
to @josancamon19 july.4.demo.mp4 |
I think this looks great, please create the proper PR for it! @SHAH-JI |
to @josancamon19 |
@SHAH-JI I don't see any changes to memory_detail component? where did you put the new component? |
to @josancamon19 |
Perfect, please include it on memory detail @SHAH-JI |
to @josancamon19
|
to @josancamon19 |
to @josancamon19 |
to @josancamon19 |
to @josancamon19 |
to @josancamon19 |
This doesn't look like the sample shown.
|
to @josancamon19 |
Share a video please, and tell me if this seems like a good UI. |
Video: demo.july.16.mp4 |
to @kodjima33 |
Changes: