Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Custom Audio Player [#381] #399

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

Conversation

SHAH-JI
Copy link
Contributor

@SHAH-JI SHAH-JI commented Jul 2, 2024

Changes:

  • Initial Implementation of Custom Audio Player with 3 sample audio files
  • Main Screen changed to AudioPlayerTest for testing purposes

@josancamon19
Copy link
Contributor

Hi @SHAH-JI please upload a video showing the functionality please. Also, if it's initial implementation, created instead a Draft PR. Thanks

@SHAH-JI SHAH-JI marked this pull request as draft July 3, 2024 08:34
@SHAH-JI
Copy link
Contributor Author

SHAH-JI commented Jul 3, 2024

to @josancamon19
Please check the demo below and let me know, if any changes are required.
Thanks.
https://github.com/BasedHardware/Friend/assets/25644067/28c11495-c322-49b7-8da1-43fac073d8b4

@josancamon19
Copy link
Contributor

It looks good in terms of functionality, not in terms of UI. @SHAH-JI

@SHAH-JI
Copy link
Contributor Author

SHAH-JI commented Jul 4, 2024

to @josancamon19 Can you share the UI part which needs improvement?

@SHAH-JI
Copy link
Contributor Author

SHAH-JI commented Jul 4, 2024

to @josancamon19
Here are some UI improvements and also added playback speed change.

july.4.demo.mp4

@josancamon19
Copy link
Contributor

josancamon19 commented Jul 5, 2024

I think this looks great, please create the proper PR for it! @SHAH-JI

@SHAH-JI SHAH-JI marked this pull request as ready for review July 5, 2024 03:29
@SHAH-JI
Copy link
Contributor Author

SHAH-JI commented Jul 5, 2024

to @josancamon19
Sure, I have moved the PR from draft to Ready for Review, please check.

@josancamon19
Copy link
Contributor

@SHAH-JI I don't see any changes to memory_detail component? where did you put the new component?

@SHAH-JI SHAH-JI marked this pull request as draft July 5, 2024 14:56
@SHAH-JI
Copy link
Contributor Author

SHAH-JI commented Jul 5, 2024

to @josancamon19
The new component is in lib/pages/memories/widget/custom_audio_player.dart

@josancamon19
Copy link
Contributor

Perfect, please include it on memory detail @SHAH-JI

@SHAH-JI SHAH-JI marked this pull request as ready for review July 6, 2024 16:39
@SHAH-JI
Copy link
Contributor Author

SHAH-JI commented Jul 6, 2024

to @josancamon19
Following changes are done:

  1. Module added in memory_detail
  2. Effective commenting for better understanding
  3. Added Support for temporary cache directory (app storage files)

@josancamon19
Copy link
Contributor

CleanShot 2024-07-06 at 11 51 47@2x
I don't understand what's this.

This should play of course the audio from the memory recording

@SHAH-JI
Copy link
Contributor Author

SHAH-JI commented Jul 7, 2024

to @josancamon19
Please pull the new changes, with my 2nd last commit I have added the support for the file in cache (Audio from memory recording). On CustomAudioPlayer initialization, you just need to provide the FileType and it will start working.

@SHAH-JI
Copy link
Contributor Author

SHAH-JI commented Jul 7, 2024

to @josancamon19
Also, the AudioPlayerTestPage is an example widget on how to use different files types. It is not part of the Custom Audio Player UI.

@josancamon19
Copy link
Contributor

Please include the component as part of the UI of memory_detail. with memory.recordingPath field.
Uploading CleanShot 2024-07-06 at 23.31.56@2x.png…

@SHAH-JI
Copy link
Contributor Author

SHAH-JI commented Jul 8, 2024

to @josancamon19
AudioPlayer has to be added on the Summary tab? If yes can you also point out the position?

@SHAH-JI
Copy link
Contributor Author

SHAH-JI commented Jul 9, 2024

to @josancamon19
Please check the screen and let me know if there are any changes to be done. Thanks
https://github.com/BasedHardware/Friend/assets/113975718/fe78aee7-1eaa-46cd-acac-bdd89fc77f61

@mshahjahan-mufin
Copy link

to @josancamon19
I am waiting for your response.

@josancamon19
Copy link
Contributor

This doesn't look like the sample shown.

  1. How is this going to go on the list item of the memory, that makes absolute nonsense.
  2. Looks terrible in memory detail.

@SHAH-JI
Copy link
Contributor Author

SHAH-JI commented Jul 15, 2024

to @josancamon19
Now it same like the sample and remove the Audio Player from list item. Please check the below screenshot:
WhatsApp Image 2024-07-15 at 13 12 29

@josancamon19
Copy link
Contributor

Share a video please, and tell me if this seems like a good UI.

@SHAH-JI
Copy link
Contributor Author

SHAH-JI commented Jul 16, 2024

to @josancamon19

  1. Here is the app video, please let me know if there are any changes to be made.
  2. As for the UI, in my opinion it is good as of now.
  3. Please make the google-services.json and firebase_options.dart files available. It makes difficult to work on the project without them.

Video:

demo.july.16.mp4

@SHAH-JI
Copy link
Contributor Author

SHAH-JI commented Aug 7, 2024

to @kodjima33
Can you please check this comment and let me know if there are any changes: #399 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants