Don't recreate scorecard clients multiple times

Signed-off-by: Raghav Kaul <[email protected]>
Ballalkhan · Jan 5, 2024 · b9a43c0 · b9a43c0
1 parent 968a887
commit b9a43c0
Showing 1 changed file with 3 additions and 4 deletions.
diff --git a/pkg/scorecard/scorecard.go b/pkg/scorecard/scorecard.go
@@ -62,17 +62,16 @@ func Get(ctx context.Context, fullRepo string, tr http.RoundTripper) (*ScClient,
  } else {
  mMutex.RUnlock()
  }
- mMutex.RLock()
+ mMutex.Lock()
  if scc, ok := scClients[fullRepo]; ok {
- mMutex.RUnlock()
+ mMutex.Unlock()
  return scc, nil
  }
- mMutex.RUnlock()
  scc, err := create(ctx, fullRepo, tr)
  if err != nil {
+ mMutex.Unlock()
  return nil, err
  }
- mMutex.Lock()
  scClients[fullRepo] = scc
  mMutex.Unlock()
  return scc, nil