Generate preview on mail creation / update #316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jessy-BAER
reviewed
Apr 13, 2021
|
|
||
| // not awaited on purpose | ||
| mailingService.generateMailingPreview(mailingId, req.cookies); | ||
|
|
||
| res.json(mailingForMosaico); |
There was a problem hiding this comment.
you must send the response before the preview
| @@ -156,6 +158,9 @@ async function createInsideWorkspaceOrFolder(mailingData) { | |||
|
|
|||
| const newMailing = await createMailing(mailing); | |||
|
|
|||
| // not awaited on purpose | |||
| generateMailingPreview(newMailing._id, cookies); | |||
There was a problem hiding this comment.
it's better to not add this logique in this service but to call preview generation directly in controller
| const stream = await fs.createReadStream(file.path); | ||
|
|
||
| if (config.isAws) { | ||
| const prefix = `groups/${_company}/mailings/${mailingId}/preview`; |
There was a problem hiding this comment.
prefix must be use also without aws, generation must be store in folder
packages/server/utils/storage-s3.js
Outdated
| } | ||
| ) | ||
| .on('httpUploadProgress', (progress) => { | ||
| console.log( |
There was a problem hiding this comment.
Change console in this file with logger
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#299