Embedded support for compilation on Windows #6624
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1616ec0
to
4d4ee34
Compare
4d4ee34
to
8575e86
Compare
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #6623
Here I have embedded very simple and light additions/modifications to the code for being able to compile on Windows.
This does not include orchestration of dependencies, protobuf etc. As we do it with other tools, mainly Conan.
But as long as you drag all the sources to an MSVC project, and set the include folders and required preprocessor flags - you're good.
It works, tested on a heavily tested project.
This might also be the cornerstone for a crossplatform Conan package.