Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding in ACS SBC, WFC3 and ACS narrow, and JWST filters and enhancing the filter plotting routine #799

Merged
merged 24 commits into from
May 23, 2024
Merged

adding in ACS SBC, WFC3 and ACS narrow, and JWST filters and enhancing the filter plotting routine #799

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
105bb6f
adding in ACS HRC filters and enhancing the filter plotting routine
karllark Feb 14, 2024
e6a8e36
update variables to match reality
karllark Feb 14, 2024
5509c54
fix codestyle
karllark Feb 14, 2024
4d6980e
adding in MIRI filters
karllark Feb 15, 2024
6ce4c18
adding in NIRCam filters
karllark Feb 15, 2024
cb3cfcb
adding in NIRISS
karllark Feb 15, 2024
5da9d5e
removing extra space
karllark Feb 15, 2024
51f6aa4
extra line
karllark Feb 15, 2024
83d243b
adding in a test to make sure filters and vega hdf5 files are consisent
karllark Feb 15, 2024
b5a0498
adding dependancy
karllark Feb 15, 2024
88666af
allow new test to run remotely
karllark Feb 15, 2024
3a37ea1
fixing codestyle
karllark Feb 15, 2024
88c9db0
adding updating of vega.hd5 file
karllark Feb 15, 2024
de642f4
fixing codestyle
karllark Feb 15, 2024
5153913
making code simpler
karllark Feb 15, 2024
b93d171
adding filters doc with plots of all filters
karllark Feb 24, 2024
c27cd5e
adding in missing doc file
karllark Feb 24, 2024
acddc97
adding in filters download for RTD build
karllark Feb 24, 2024
976a25d
changing to latest regression files
karllark May 23, 2024
11e6f7f
changing the coverage test python version
karllark May 23, 2024
4e9d99b
minor
karllark May 23, 2024
08115d4
trying python 3.09 for coverage
karllark May 23, 2024
039b881
removing mac error
karllark May 23, 2024
c9590a5
removing bad doc link
karllark May 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixing codestyle
  • Loading branch information
@karllark
karllark committed May 14, 2024
commit 3a37ea16d967babd29325f0df25a6a1dba1858e4
6 changes: 3 additions & 3 deletions beast/observationmodel/tests/test_filters_and_vega_consistent.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,7 @@

from beast.config import __ROOT__
from beast.tools import get_libfiles
from beast.observationmodel.vega import Vega
from beast.observationmodel import phot


def test_filters_and_vega_consistent():
"""
Expand All @@ -29,5 +28,6 @@ def test_filters_and_vega_consistent():
otxt = f"{otxt} {cfilt}"
assert otxt == "", "filters in vega.hd5 missing from filters.hd5:" + otxt


if __name__ == "__main__": # pragma: no cover
test_filters_and_vega_consistent()
test_filters_and_vega_consistent()
3 changes: 1 addition & 2 deletions beast/tools/get_libfiles.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,7 @@ def get_libfiles(vega_filters_only=False):
Download all the library files needed by the BEAST
"""
for ckey, clib in libs.items():
if ((not vega_filters_only) or
(vega_filters_only & (ckey in ["vega", "filters"]))):
if ((not vega_filters_only) or (vega_filters_only & (ckey in ["vega", "filters"]))):
_download_rename(clib, libs_server, __ROOT__)


Expand Down