Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding in step and absexp priors of dust and dist #795

Merged
merged 13 commits into from
Dec 13, 2023

Conversation

karllark
Copy link
Member

@karllark karllark commented Dec 4, 2023

The visualizations of the Scylla and SMIDGE results have shown that the existing prior model in BEAST is not sufficient. Especially when considering the physicsmodel needed for the MegaBEAST (=BEAST prior model). Specifically, the distribution of dust and stars in distance was not modeled as anything other than flat. The stars are generally centered in the plane of a galaxy, often modeled as falling off with some exponential scale height. The is usually seen as concentrated into dust clouds that are located at a specific distance.

Two new prior models are now included "step" (for Av, Rv, fA) and "absexponential" (for dist) to make the priors more realistic.

Copy link

codecov bot commented Dec 4, 2023

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (bcf2f08) 42.30% compared to head (794901f) 42.44%.

❗ Current head 794901f differs from pull request most recent head 3bb544f. Consider uploading reports for the commit 3bb544f to get more accurate results

Files Patch % Lines
beast/physicsmodel/creategrid.py 69.23% 4 Missing ⚠️
beast/physicsmodel/priormodel.py 80.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #795      +/-   ##
==========================================
+ Coverage   42.30%   42.44%   +0.14%     
==========================================
  Files         107      108       +1     
  Lines       10096    10132      +36     
==========================================
+ Hits         4271     4301      +30     
- Misses       5825     5831       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@karllark
Copy link
Member Author

karllark commented Dec 6, 2023

Codacy analysis failure is for a complexity issue. This complexity is needed, so will ignore.

@karllark karllark merged commit bb52006 into BEAST-Fitting:master Dec 13, 2023
9 of 12 checks passed
@karllark karllark deleted the better_distance_dust_priors branch December 13, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant