Script for generating main libfile #757
Conversation
|
aaand tests failing because stsynphot is not found, and I suppose they'll always fail because in order to run stsynphot you need to download ~1 GB of supporting files... |
Tests are failing because stsynphot is not a dependency. This should just be added to the setup.cfg file. And will not require the supporting files. Just that python can load the module. Can provide more details on the needed update to setup.cfg if it is not clear. |
beast/tools/make_libfile.py
Outdated
| zip( | ||
| tablenames, | ||
| observatories, | ||
| filternames, |
There was a problem hiding this comment.
I think this should be instruments
beast/tools/make_libfile.py
Outdated
| # populate contents lists with relevant information | ||
| tablenames.append(filter_name) | ||
| observatories.append("HST") | ||
| filternames.append(mode.upper) |
There was a problem hiding this comment.
I think this should be instruments. Items could be WFC3, ACS, WFPC2, etc.
beast/tools/make_libfile.py
Outdated
| # Define arrays for "contents" / descriptive information | ||
| tablenames = [] | ||
| observatories = [] | ||
| filternames = [] |
There was a problem hiding this comment.
filternames -> instruments
I left comment about the "INSTRUMENT" column in the content group. Otherwise, the script looks good to me. You are planning to add ACS and WFPC2 filters? |
|
yes! although I will need help to figure out WFPC2... @karllark mentioned figuring out how to combine the 4 chips? if either of you have insight, please let me know! |
|
Ok I added ACS_WFC, WFPC2 and GALEX filters. Please look through the list and verify that my curating is reasonable? It's very easy to include more! Currently, after discussion with Pey-Lian Lim, the best way to list the filters is via the rather unsatisfying custom list of strings... |
|
@cmurray-astro Here is the list of filters used in LUVIT in addition to WFC3. |
I see all the LUVIT filters, as well as the filters in my own HST programs, in the current list. Thanks Claire! As we briefly talked about the ionizing photon filters, I would like to keep them separate (at least for now). The way loading and applying them are different from other filters in the current BEAST codes because we compute the number of photons, not the fluxes in those bands. |
|
Looks like a good list of filters to me. |
|
Remember to update the title when this PR is ready for review/merging. |
cmurray-astro
changed the title
|
ready for review/merging! |
|
Looks good to me! |
|
Where can I get the new library file? Need to replace the existing one. |
This is a work in progress! Fun with HDF5 formatting made this take longer than I thought, but figured I'd get what I have up ASAP. @galaxyumi plz comment! So far it only generates filters for WFC3 UVIS and IR, still looking to see if there is an easier way to grab all the filter options from stsynphot...