Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a beast_settings file instead of loading a sedgrid to figure our a list of filters in plot_toothpick_details #715

Merged

Conversation

galaxyumi
Copy link
Contributor

I saw another PR by @christinawlindberg including the same changes (#710). Mine is just for the plot_toothpick_details.py, while #710 seems to include changes in other files. @karllark Please feel free to reject or accept this PR.

@codecov-commenter
Copy link

codecov-commenter commented Oct 15, 2021

Codecov Report

Merging #715 (d99393b) into master (f5ce89d) will decrease coverage by 0.34%.
The diff coverage is 28.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #715      +/-   ##
==========================================
- Coverage   43.73%   43.39%   -0.35%     
==========================================
  Files         100      100              
  Lines        9710     9725      +15     
==========================================
- Hits         4247     4220      -27     
- Misses       5463     5505      +42     
Impacted Files Coverage Δ
beast/plotting/plot_toothpick_details.py 13.04% <28.57%> (ø)
beast/tools/compare_spec_type.py 60.86% <0.00%> (-33.92%) ⬇️
beast/fitting/pdf1d.py 89.83% <0.00%> (-3.20%) ⬇️
beast/fitting/fit.py 81.73% <0.00%> (-0.33%) ⬇️
beast/tools/read_beast_data.py 42.18% <0.00%> (ø)
beast/tools/run/run_fitting.py 19.11% <0.00%> (ø)
beast/observationmodel/ast/make_ast_xy_list.py 5.04% <0.00%> (ø)
beast/tools/subgridding_tools.py 32.59% <0.00%> (+0.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5ce89d...d99393b. Read the comment docs.

Copy link
Member

@karllark karllark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@karllark karllark merged commit 0a9e0aa into BEAST-Fitting:master Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants