Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix shellcheck file paths #786

Merged
merged 3 commits into from
Feb 1, 2022
Merged

Conversation

aramase
Copy link
Member

@aramase aramase commented Feb 1, 2022

Signed-off-by: Anish Ramasekar [email protected]

Reason for Change:

  • shellcheck */*.sh doesn't check all the shell files in the repo. Changing to use find all files and then run shellcheck.
  • Fixes errors

Requirements

  • squashed commits
  • included documentation
  • added unit tests and e2e tests (if applicable).

Issue Fixed:

Does this change contain code from or inspired by another project?

  • Yes
  • No

If "Yes," did you notify that project's maintainers and provide attribution?

Special Notes for Reviewers:

Signed-off-by: Anish Ramasekar <[email protected]>
Signed-off-by: Anish Ramasekar <[email protected]>
@aramase
Copy link
Member Author

aramase commented Feb 1, 2022

@aramase aramase requested a review from nilekhc February 1, 2022 19:52
@aramase aramase mentioned this pull request Feb 1, 2022
5 tasks
@aramase aramase enabled auto-merge (squash) February 1, 2022 20:02
@aramase aramase merged commit 4f79862 into Azure:master Feb 1, 2022
@aramase aramase deleted the update-shellcheck branch February 1, 2022 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants