OAI2-> OAI3: Fail if there is no produces provided for a path and the response has a schema/body #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think we want it to fail in the pipeline because this is an issue that we can't resolve. I'm fine with it being a breaking change from that perspective. Is it possible this will be a breaking change for the TS library since we're changing typings on function signatures? Should we bump major version for that? |
daviwil
approved these changes
Jan 15, 2021
|
It is a different type but what is being used is an abstraction on top of the datahandle which doesn't involve this change. export const convertOai2ToOai3Files = async (inputFiles: DataHandle[]): Promise<OaiToOai3FileOutput[]>I think just bumping to 4.2 should be good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should resolve the confusion this cause later in the pipeline: Azure/autorest#3680
This is however a breaking change(Not really used inside of autorest as it would just fail later in the pipeline, so if we don't care about that we can do this)
Alternatives:
Also include a few cleanup(including some basic typing for OAI2 schema)