feat: calculate the time we need to wait for the first applied but not ready binding to be ready. #888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
britaniar
force-pushed
the
waitTime
branch
2 times, most recently
from
3cb80bd
to
4b8bdb0
Compare
zhiying-lin
reviewed
Jul 29, 2024
| // return wait time longer if the rollout is stuck on failed apply/available bindings | ||
| allReady := true | ||
| minWaitTime := time.Duration(*crp.Spec.Strategy.RollingUpdate.UnavailablePeriodSeconds) * time.Second / 5 |
There was a problem hiding this comment.
the minWaitTime should be 0 regardless of the UnavailablePeriodSeconds
| // return wait time longer if the rollout is stuck on failed apply/available bindings | ||
| allReady := true |
There was a problem hiding this comment.
is this still needed?
|
|
||
| // Process unscheduled bindings | ||
| func (r *Reconciler) processUnscheduledBinding( | ||
| crpKObj, bindingKObj klog.ObjectRef, |
There was a problem hiding this comment.
I thought about refactoring the func but the parameters are so huge so I gave up. I guess it's still worth it.
However, we can get rid of ObjectRef.
We should also make sure what are the input vs output
Comment on lines
+386
to
+387
| readyBindings, canBeReadyBindings, canBeUnavailableBindings *[]*fleetv1beta1.ClusterResourceBinding, | ||
| removeCandidates *[]toBeUpdatedBinding, |
There was a problem hiding this comment.
these are output. I am not sure if there is any clean way to distinguish them
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes #
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
Special notes for your reviewer