fix: address NaN output in weight interpolation #883
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -245,6 +245,16 @@ func interpolateWeightFor(cluster *clusterv1beta1.MemberCluster, property string | |||
| return 0, fmt.Errorf("cannot interpolate weight, observed value %v, observed min %v, observed max %v", f, minF, maxF) | |||
| } | |||
|
|
|||
| if minF == maxF { | |||
There was a problem hiding this comment.
is there a test case for this?
There was a problem hiding this comment.
Hi Ryan! I have moved some UTs from another PR to this one for review purposes. The UTs for types.go were not checked in earlier 😣
|
Note: the fix itself has been checked in with an earlier PR; closing this one as its content has been included in #887. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
This PR fixes an issue where weight interpolation will yield a NaN value when a property is of the same value across the fleet.
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
Special notes for your reviewer
Unit tests for the file have not been checked in before; will submit a separate PR.