Stop creating PR to update TPN files #9989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shenglol
approved these changes
Mar 3, 2023
| draft: false | ||
| commit_options: '--no-verify --signoff' | ||
| status_options: '--untracked-files=no' | ||
| push_options: '--force' |
There was a problem hiding this comment.
Why force push? Isn't that going to blow away someone else's commit?
There was a problem hiding this comment.
It needs to blow away its own changes too because we're not going to create a PR every time it runs. Everyone in this repo is following the convention of having their username in the branch name, so there shouldn't be clashes ideally but it is a temporary solution until we figure out how to get PR creation automation working again.
There was a problem hiding this comment.
Ah - I missed that this isn't running on the main branch. Makes sense.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the permissions got locked down, we can no longer use workflows to automatically create PRs. Removed the PR creation step and replaced it with a force push step. The PR will be created manually from the branch.
Microsoft Reviewers: Open in CodeFlow