Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update survey dialog text #9837

Merged
merged 1 commit into from
Feb 14, 2023
Merged

Update survey dialog text #9837

merged 1 commit into from
Feb 14, 2023

Conversation

StephenWeatherford
Copy link
Contributor

@StephenWeatherford StephenWeatherford commented Feb 13, 2023

Microsoft Reviewers: Open in CodeFlow

@@ -131,7 +131,7 @@ describe("surveys-unittests", () => {

// Show and respond with yes
mocks.showInformationMessageMock.mockResolvedValueOnce(<MessageItem>{
title: "Sure",
title: "Jawohl",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be - Yes?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, title may be localized, it shouldn't matter what it is

@StephenWeatherford StephenWeatherford merged commit eeeeab7 into main Feb 14, 2023
@StephenWeatherford StephenWeatherford deleted the sw/survey-changes2 branch February 14, 2023 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants