-
Notifications
You must be signed in to change notification settings - Fork 742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New parameter --force
on Publish command
#9745
Conversation
As far as I can tell, it's working as expected with Can you have a look and see if the design looks good otherwise? And in that case, a pointer or two would be great on where I should get started on the testing. Thanks! |
@majastrz maybe you could have a look when you have time? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added some comments. Please take a look.
Since the tests ensured functionality by publishing twice and checking that only one module was published, I decided to modify them to also account for the I've also adjusted to use the blob client to pull and check manifest instead, and removed the traces of the registry client. Take a look when you have time @majastrz 🙂 |
@PalmEmanuel sorry for the delay with the review. I added a couple more comments. Can you take a look when you get a chance? |
…r exception kind, CheckModuleExists() now catches it and checks kind
Added some changes according to your feedback. See my comment in resolved conversation when you have time @majastrz |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! |
Contributing a feature
Fixes #4757
Microsoft Reviewers: Open in CodeFlow