New parameter --force on Publish command

[PalmEmanuel]

Contributing a feature

• I have opened a new issue for the proposal, or commented on an existing one, and ensured that the Bicep maintainers are good with the design of the feature being implemented
• I have included "Fixes #{issue_number}" in the PR description, so GitHub can link to the issue and close it when the PR is merged
• I have appropriate test coverage of my new feature

Fixes #4757

Microsoft Reviewers: Open in CodeFlow

[PalmEmanuel]

As far as I can tell, it's working as expected with bicep publish now giving an error if a module with the same tag exists in the oci registry, unless using --force. I implemented the module-existing-check using the ContainerRegistryClient (not Blob) which made it a little bit intimidating to get started on testing stuff since it requires a new mocking structure for the client unless I'm mistaken.

Can you have a look and see if the design looks good otherwise? And in that case, a pointer or two would be great on where I should get started on the testing. Thanks!

[PalmEmanuel]

@majastrz maybe you could have a look when you have time?

[majastrz]

I added some comments. Please take a look.

[PalmEmanuel]

Since the tests ensured functionality by publishing twice and checking that only one module was published, I decided to modify them to also account for the --force option. If we'd rather have that as separate tests I can break them out.

I've also adjusted to use the blob client to pull and check manifest instead, and removed the traces of the registry client. Take a look when you have time @majastrz 🙂

[majastrz]

@PalmEmanuel sorry for the delay with the review. I added a couple more comments. Can you take a look when you get a chance?

[PalmEmanuel]

Added some changes according to your feedback. See my comment in resolved conversation when you have time @majastrz

[majastrz]

[majastrz]

LGTM!