Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LoadJsonContent supports file with comments #9222

Merged
merged 2 commits into from
Dec 8, 2022
Merged

LoadJsonContent supports file with comments #9222

merged 2 commits into from
Dec 8, 2022

Conversation

miqm
Copy link
Collaborator

@miqm miqm commented Dec 6, 2022 •
edited
Loading

Fixes #8944

Contributing a Pull Request

Contributing a feature

  • I have opened a new issue for the proposal, or commented on an existing one, and ensured that the Bicep maintainers are good with the design of the feature being implemented
  • I have included "Fixes #{issue_number}" in the PR description, so GitHub can link to the issue and close it when the PR is merged
  • I have appropriate test coverage of my new feature
Microsoft Reviewers: Open in CodeFlow

@anthony-c-martin anthony-c-martin enabled auto-merge (squash) December 8, 2022 00:52
@anthony-c-martin
Copy link
Member

Thanks for fixing this!

@anthony-c-martin anthony-c-martin merged commit c9a75f5 into Azure:main Dec 8, 2022
@anthony-c-martin anthony-c-martin deleted the feat/jsonc-support branch December 8, 2022 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anthony-c-martin anthony-c-martin anthony-c-martin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

loadJsonContent() fails to handle JSONC comments where json(loadTextContent() succeeds
2 participants
@miqm @anthony-c-martin