Add LSP benchmark #9157
Merged
Add LSP benchmark #9157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeskew
approved these changes
Nov 30, 2022
There was a problem hiding this comment.
I see in the graphic provided that IFeatureProvider (which is doing disk seeks) is also taking up a big chunk of time, and that makes it look like the language server is I/O bound. If we're using the JSON serializer in streaming mode, we might be able to speed things up by buffering responses before writing any data.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It felt like this would be useful to have for future perf investigations!
Some interesting initial data it turned up - creating built-in namespaces is responsible for 42% of time spent when upserting compilations, and serializing diagnostics to publish is responsible for an additional 37%!
Microsoft Reviewers: Open in CodeFlow