Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vscode): add icons for container apps #9101

Merged
merged 1 commit into from
Nov 23, 2022

Conversation

matsest
Copy link
Contributor

@matsest matsest commented Nov 22, 2022

Contributing a Pull Request

If you haven't already, read the full contribution guide. The guide may have changed since the last time you read it, so please double-check. Once you are done and ready to submit your PR, run through the relevant checklist below.

Description

Icons downloaded from https://learn.microsoft.com/en-us/azure/architecture/icons/

From debug build:

image

Microsoft Reviewers: Open in CodeFlow

- add icon for microsoft.app/containerapps (fixes Azure#9094)
- add icon for microsoft.app/managedenvironments (fixes Azure#9093)
Copy link
Contributor

@shenglol shenglol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for adding the icons!

@shenglol shenglol merged commit b4a281e into Azure:main Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong Icon for Container Apps Wrong Icon for Azure Container Environment
2 participants