Enable bicep-params language in GH builds
#8671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majastrz
force-pushed
the
majastrz/nightly-params
branch
from
200ea35
to
8cdf912
Compare
majastrz
force-pushed
the
majastrz/nightly-params
branch
from
1a14ab5
to
fb13d99
Compare
jeskew
reviewed
Oct 17, 2022
| "json-ptr": "^3.1.0", | ||
| "jsonpath": "^1.1.1", | ||
| "lodash.range": "^3.2.0", | ||
| "vm2": "^3.9.9" |
There was a problem hiding this comment.
Not related to your change, but 🤔 this is a way bigger dependency closure than I would have expected for a deepmerge function.
jeskew
reviewed
Oct 17, 2022
| { | ||
| "language": "bicep-params", | ||
| "scopeName": "source.bicep", | ||
| "path": "./syntaxes/bicep.tmlanguage" |
There was a problem hiding this comment.
Not in scope for this PR, but will bicep param files need a separate textmate grammar?
There was a problem hiding this comment.
I'm not sure. @anthony-c-martin, thoughts?
jeskew
approved these changes
Oct 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extremely hacky solution to enable params language on GH builds. (Official builds are not affected.)
Local builds by default do not enable params unless you specifically run
npm run paramsin/src/vscode-bicep. If you do don't accidentally check in the modifiedpackage.json.I looked for various CLI based options first, but ran either into wrong merge behaviors (replacing arrays completely), or packages had vulnerabilities or their last update was years ago. In the end, I decided to just hack up a tiny JS script and exclude it from eslint, so it doesn't complain about the project file not matching.
Microsoft Reviewers: Open in CodeFlow